Closed
Bug 1482780
Opened 6 years ago
Closed 6 years ago
"Add to Thunderbird" in add-ons manager warns ""Thunderbird prevented the site (addons.thunderbird.net) from asking you to install software on your computer."" And links in the tab open in a browser Tab
Categories
(Thunderbird :: Add-Ons: General, defect)
Tracking
(thunderbird_esr6064+ fixed)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: unicorn.consulting, Assigned: mkmelin)
References
()
Details
Attachments
(2 files)
Search for an addon in Thunderbird addon manager.
I used the word "image" and clicked on the title link and the link opened in Firefox. (Browser)
Clicking the Add to Thunderbird for the Shrunken image resize addon pops up a "Thunderbird prevented the site (addons.thunderbird.net) from asking you to install software on your computer.
While there was an option to Allow in the message that appeared across the top of the addon manager tab, it does not look good to be blocking our own addon site by default.
Updated•6 years ago
|
Component: General → Add-Ons: General
Comment 1•6 years ago
|
||
This does seem weird, and would be confusing to users.
It also seems like this would be a duplicate in https://mzl.la/2Nee6iU or toolkit?
Summary: addons.thunderbird.net is blocked from installing addons and links in the tab open in a browser Tab → "Add to Thunderbird" in add-ons manager is blocked ""Thunderbird prevented the site (addons.thunderbird.net) from asking you to install software on your computer."" And links in the tab open in a browser Tab
Comment 2•6 years ago
|
||
This is some weird permissions thing. I think Bug 1072748 needs to be fixed and addons.thunderbird.net needs to be added to said default permissions file for this to work, or something like that.
I tried to fiddle with the xpi install whitelist prefs a while ago but I couldn't get them to do anything at all. Not sure they even work.
Comment 3•6 years ago
|
||
IMO, this is blocker to fully automatic updates.
(technically we could say it's not a blocker, but it is intimidating and we really shouldn't be kicking the can down the road on something like this)
Severity: normal → blocker
Depends on: 1072748
Comment 4•6 years ago
|
||
I agree it's serious, but I'm not convinced it's a blocker namely because it isn't a regression. You'll still get this in TB52 because it's also using addons.thunderbird.net via redirects AND the Add-on install process is broken by many other bugs in addition.
That all depends on how much time it will take to fix this and get it into a new build, of course. But we get a lot of people complaining about installation issues in TB52 that are partially or fully fixed in 60.2.1.
Comment 5•6 years ago
|
||
good info. But I've never seen it before recently. Why I'm seeing it now someone else is welcome to figure out if they want - maybe it's 60.2.1? dunno
Anyway, I anticipate we will do a 60.2.2 for anything that's needed before we unthrottle updates.
My understanding of the technical here is sketchy. But if we update and addons do not get updated even though there is a compatible version around, then there is be a lot of noise about broken updates and requests for the ubiquitous "roll back version"
Comment 7•6 years ago
|
||
As far as I know, none of this stops automatic updates and automatic updates are still working fine. If they're NOT working fine, that would be a serious bug.
Comment 8•6 years ago
|
||
(In reply to Andrei Hajdukewycz [:sancus] from comment #7)
> As far as I know, none of this stops automatic updates and automatic updates
> are still working fine. If they're NOT working fine, that would be a serious bug.
This isn't about whether Thunderbird can automatically update nor even whether add-ons will automatically update.
Many users will be looking for alternatives to add-ons that are NO longer compatible. And therein lies the issue.
I agree with Matt, users are very sensitive about the add-ons situation, have a low tolerance for updates not working (regardless of the reason), and will roll back. As more add-ons get properly compatible it will be less of an issue, but as we all know, the current state of add-ons is somewhat mediocre.
Unless someone can convince me the issue is less severe than my current understanding (perhaps it's only a few add-on? If so, what is the list?) this will be a blocker to unthrottling updates, modulo a serious security vulnerability forcing us to unthrottle.
Comment 9•6 years ago
|
||
I understand this bug isn't about automatic updates but Matt's comment sounded like he was concerned about those... "addons do not get updated even though there is a compatible version around.". This bug shouldn't cause that to happen.
I agree with the rest of your comment :)
Comment 10•6 years ago
|
||
I had forgotten about this before enabling updates. :(
This is exceptionally poor user experience.
Plus we're training users to click "allow" for a potential "security" situation - which should be the exception, not the rule.
(In reply to Andrei Hajdukewycz [:sancus] from comment #2)
> This is some weird permissions thing. I think Bug 1072748 needs to be fixed
> and addons.thunderbird.net needs to be added to said default permissions
> file for this to work, or something like that.
Magnus can we please make bug 1072748 happen ASAP?
status-thunderbird_esr60:
--- → affected
Flags: needinfo?(mkmelin+mozilla)
OS: Windows 10 → All
Summary: "Add to Thunderbird" in add-ons manager is blocked ""Thunderbird prevented the site (addons.thunderbird.net) from asking you to install software on your computer."" And links in the tab open in a browser Tab → "Add to Thunderbird" in add-ons manager warns ""Thunderbird prevented the site (addons.thunderbird.net) from asking you to install software on your computer."" And links in the tab open in a browser Tab
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
jeez it gets even worse - next another dialog is thrown up which says
Install add-ons only from authors whom you trust.
Even though I have downloaded from our official site.
Assignee | ||
Comment 13•6 years ago
|
||
With the patch from bug 1072748 I don't get the warning
Assignee: nobody → mkmelin+mozilla
Flags: needinfo?(mkmelin+mozilla)
Comment 14•6 years ago
|
||
Fixed by bug 1072748. That was uplifted to TB 60 ESR and I verified it there.
The "Software Installation" Windows is launched immediately, however, as per comment #12 the wording there is:
Install add-ons only from authors whom you trust.
But that's not the subject of this bug. Note that the search behaviour in TB 52 was different. Search didn't open a new tab but instead added a new pane to the Add-ons Manager. That pane showed a list of matches and clicking the "Install" button installed the add-on without any further ado.
Status: NEW → RESOLVED
Closed: 6 years ago
tracking-thunderbird_esr60:
--- → 64+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in
before you can comment on or make changes to this bug.
Description
•