Closed
Bug 1482866
Opened 6 years ago
Closed 6 years ago
Simplify AttrArray now that it doesn't store kids.
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
Now that children don't need to be stored, this may be simpler.
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
No need for void* stuff, but I had to keep the semi-manual memory
management to allocate everything inline as we currently do.
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8999642 [details]
Simplify AttrArray's implementation. r=smaug
Olli Pettay [:smaug] has approved the revision.
Attachment #8999642 -
Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cba97273eb10
Simplify AttrArray's implementation. r=smaug
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cba97273eb10#l2.178
This doesn't compile in MSVS C++:
+ // Allocated in the same buffer as `Impl`.
+ InternalAttr mBuffer[0];
1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): error C2220: warning treated as error - no 'object' file generated
1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): warning C4200: nonstandard extension used: zero-sized array in struct/union
1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): note: This member will be ignored by a defaulted constructor or copy/move assignment operator
Flags: needinfo?(emilio)
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•