William Lachance (:wlach) Assignee
	Description • 6 years ago

To support mozregression, which is mostly used with unrooted devices, we should make it possible to initialize ADB without root permissions (this was broken in bug 1440714).

	Bob Clary [:bc] (inactive)
	Comment 2 • 6 years ago

Comment on attachment 8999626 [details] [diff] [review]
Patch to make root requirement optional

Review of attachment 8999626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me. This is sufficient to allow mozregression to work? r+

	William Lachance (:wlach) Assignee
	Comment 3 • 6 years ago

(In reply to Bob Clary [:bc:] from comment #2)
> Comment on attachment 8999626 [details] [diff] [review]

> Looks ok to me. This is sufficient to allow mozregression to work? r+

I believe so, haven't tested mozregression itself but am 99% sure.

Here's a try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fe4935382c28742440da69ef00be0cfc85a0f81

	William Lachance (:wlach) Assignee
	Comment 4 • 6 years ago

Adding a version bump to mozdevice, carrying forward r+

	William Lachance (:wlach) Assignee
	Comment 5 • 6 years ago

Try run looks good, can someone land this for me?

	Pulsebot
	Comment 6 • 6 years ago

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f69e8083284
Support running adb commands in mozdevice as non-root;r=bc

	Daniel Varga [:dvarga]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6f69e8083284

	William Lachance (:wlach) Assignee
	Comment 9 • 6 years ago

The above patch actually didn't quite fix things :( Sorry for the churn

	William Lachance (:wlach) Assignee
	Comment 10 • 6 years ago

Actually, I forgot that we should file followups if additional changes are asked for, I'll do that: bug 1483221