Closed Bug 1483085 Opened 6 years ago Closed 6 years ago

Update Screenshots' Action ID in the List of Built-In Page Actions

Categories

(Firefox :: Screenshots, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bchen, Assigned: bchen)

References

Details

Attachments

(1 file)

Per :adw's comment at https://bugzilla.mozilla.org/show_bug.cgi?id=1466575#c29, pageActions.jsm has a list of built-in actions (https://dxr.mozilla.org/mozilla-central/source/browser/modules/PageActions.jsm#1049) that's used when logging telemetry. Bug 1466575 changed the action ID for Screenshots from "screenshots" to "screenshots_mozilla_org", so the ID in that list needs to be updated accordingly.
Assignee: nobody → bchen
Status: NEW → ASSIGNED
Update the page action id for Screenshots in the list of built-in actions because Screenshots now use WebExtension pageAction instead of Photon.
Blocks: 1466575
Blocks: 1422437
Blocks: 1483591
Comment on attachment 8999944 [details] Bug 1483085 - Update Screenshots' id in built-in page actions list; r?adw Drew Willcoxon :adw has approved the revision.
Attachment #8999944 - Flags: review+
Sorry, I missed something in the previous patch: the telemetry histogram labels cannot end with '_' (underscore character). I will submit a new patch.
:adw I don't know how Phabricator notifications work, so in case it didn't notify you about the updated patch, please see my comment above (Comment 3). Thanks!
Sorry Barry, I had accepted the previous revision, so I didn't know you wanted review on the new revision.
I'll plan to land this along with the patch to reapply the webextension page action (bug 1466575).
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c5c05819c24 Update Screenshots' id in built-in page actions list; r=adw
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f87185545a4 Update Screenshots' id in built-in page actions list; r=adw
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: