Closed
Bug 1483148
Opened 6 years ago
Closed 6 years ago
javascript: bookmarklets no longer work after disallowInheritPrincipal bug 1466801
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | + | fixed |
People
(Reporter: cpeterson, Assigned: jkt)
References
Details
(Keywords: regression, Whiteboard: [fxsearch])
Attachments
(1 file)
[Tracking Requested - why for this release]:
This is a functionality regression in 63 Nightly. I bisected this regression to the following pushlog, which points to disallowInheritPrincipal bug 1466801:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9112406a54a2d3806112111620f25267203a992e&tochange=b5e9fdddf12e598962d6282a4b053aa66b7aabda
STR:
1. Install a javascript: bookmarklet, such as this Hacker News bookmarklet to submit links to Hacker News, by dragging it to your bookmarks toolbar:
https://news.ycombinator.com/bookmarklet.html
2. Click the Hacker News bookmarklet.
EXPECTED RESULT:
Hacker News' link submission page should be opened.
ACTUAL RESULT:
Nothing happens.
Reporter | ||
Comment 1•6 years ago
|
||
This bug is a regression from disallowInheritPrincipal bug 1466801.
Blocks: 1466801
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jkt
Assignee | ||
Comment 2•6 years ago
|
||
Comment 4•6 years ago
|
||
FWIW, they still work when you execute them using the custom keyword, if any. However, if you try to execute them using the keyword and pressing Alt+Enter to open them in a new tab, they don't work. Open the new tab first, and then execute it using the keyword as a temporary workaround.
Updated•6 years ago
|
Priority: -- → P1
Whiteboard: [fxsearch]
Comment 5•6 years ago
|
||
(In reply to Jan Moesen from comment #4)
> FWIW, they still work when you execute them using the custom keyword, if
> any. However, if you try to execute them using the keyword and pressing
> Alt+Enter to open them in a new tab, they don't work. Open the new tab
> first, and then execute it using the keyword as a temporary workaround.
Please file that as a separate bug under the address bar. Keywords work differently to bookmarks on the toolbar.
Comment 6•6 years ago
|
||
(In reply to Jonathan Kingston [:jkt] (Away until 20th Aug) from comment #2)
> Created attachment 8999879 [details]
> Bug 1483148 - Add allowInheritPrincipal to current tab bookmarklets.
Why only the current tab? As far as I can tell, the use case for middle-clicking a javascript bookmarklet on the toolbar is still broken.
Flags: needinfo?(jkt)
Comment 7•6 years ago
|
||
Filed bug 1484741.
Comment 8•6 years ago
|
||
Comment on attachment 8999879 [details]
Bug 1483148 - Add allowInheritPrincipal to current tab bookmarklets.
:Gijs (he/him) has approved the revision.
Attachment #8999879 -
Flags: review+
Assignee | ||
Comment 9•6 years ago
|
||
> Why only the current tab? As far as I can tell, the use case for middle-clicking a javascript bookmarklet on the toolbar is still broken.
From my testing it only is needed when it is applying to the current document rather than creating it's own document. However I will double check tomorrow. Also perhaps we can just use the document principal in this case instead.
Flags: needinfo?(jkt)
Comment 10•6 years ago
|
||
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d88272387d1
Add allowInheritPrincipal to current tab bookmarklets. r=Gijs
Comment 11•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•