Closed Bug 1483730 Opened 6 years ago Closed 6 years ago

Enable testNoTargetBinaries on Windows

Categories

(DevTools :: about:debugging, enhancement)

Product:
DevTools
Component:
about:debugging
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1483730 - Call nsIFile.exists method. r=jdescottes
(deleted), text/x-phabricator-request
jdescottes
: review+
Details
Bug 1483730 - Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes
(deleted), text/x-phabricator-request
jdescottes
: review+
Details
I am going to fix this apart from testStartAndStop and testTrackDevices.
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Comment on attachment 9001463 [details] Bug 1483730 - Call nsIFile.exists method. r=jdescottes Julian Descottes (PTO - back Aug 27) [:jdescottes][:julian] has approved the revision.
Attachment #9001463 - Flags: review+
Comment on attachment 9001464 [details] Bug 1483730 - Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes Julian Descottes (PTO - back Aug 27) [:jdescottes][:julian] has approved the revision.
Attachment #9001464 - Flags: review+
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/248f68b88c18 Call nsIFile.exists method. r=jdescottes https://hg.mozilla.org/integration/mozilla-inbound/rev/f523b181c03f Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/248f68b88c18 https://hg.mozilla.org/mozilla-central/rev/f523b181c03f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: