Closed Bug 1483760 Opened 6 years ago Closed 6 years ago

Environment Variables are not passed to cargo for MinGW Windows Builds

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Product:
Firefox Build System
Component:
General: Unsupported Platforms
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1483760 Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted
(deleted), text/x-phabricator-request
ted
: review+
Details
No description provided.
Previously we weren't passing the variables if we were compiling for Windows when really we only want to do it if we're compiling with MSVC/clang-cl. The MinGW-Clang build needs this.
Comment on attachment 9001483 [details] Bug 1483760 Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted Ted Mielczarek [:ted] [:ted.mielczarek] has approved the revision.
Attachment #9001483 - Flags: review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f64306b8f83 Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f64306b8f83
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: