Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 6 years ago

      No description provided.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=104337fa4aae8457cb79268fdb3ed407c5de0051

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 6 years ago

nsITableEditor::InsertTableColumn() is an XPCOM method but it's used internally.
So, HTMLEditor should implement it with a non-virtual method and internal
users should use it instead.

	Makoto Kato [:m_kato]
	Comment 4 • 6 years ago

Comment on attachment 9010264 [details]
Bug 1484116 - part 0: Add automated tests for nsITableEditor.insertTableColumn()

Makoto Kato [:m_kato] has approved the revision.

	Makoto Kato [:m_kato]
	Comment 5 • 6 years ago

Comment on attachment 9010265 [details]
Bug 1484116 - part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn()

Makoto Kato [:m_kato] has approved the revision.

	Pulsebot
	Comment 6 • 6 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c7af8a8d767a
part 0: Add automated tests for nsITableEditor.insertTableColumn() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c44ff40b9ade
part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn() r=m_kato

	Eliza Balazs [:ebalazs_]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c7af8a8d767a
https://hg.mozilla.org/mozilla-central/rev/c44ff40b9ade