Closed
Bug 1484119
Opened 6 years ago
Closed 6 years ago
Split HTMLEditor::DeleteTableCell() for internal use
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
No description provided.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Although this has a lot of todo_is() since this API is really broken.
Assignee | ||
Comment 3•6 years ago
|
||
nsITableEditor::DeleteTableCell() is an XPCOM method but used internally.
So, HTMLEditor should implement it with non-virtual method and use it
internally.
Assignee | ||
Comment 4•6 years ago
|
||
HTMLEditor::DeleteTableCellWithTransaction() does not remove <table> element
even if it becomes empty only when 2 or more cell elements are selected.
Therefore, we should check table size before removing a row and if it's the
last row, the method should remove <table>.
Comment 5•6 years ago
|
||
Comment on attachment 9010003 [details]
Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html
Makoto Kato [:m_kato] has approved the revision.
Attachment #9010003 -
Flags: review+
Comment 6•6 years ago
|
||
Comment on attachment 9010004 [details]
Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell()
Makoto Kato [:m_kato] has approved the revision.
Attachment #9010004 -
Flags: review+
Comment 7•6 years ago
|
||
Comment on attachment 9010005 [details]
Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty
Makoto Kato [:m_kato] has approved the revision.
Attachment #9010005 -
Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/5e85c1d06616
part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c5c4ddcd12a9
part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf2ee1753201
part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e85c1d06616
https://hg.mozilla.org/mozilla-central/rev/c5c4ddcd12a9
https://hg.mozilla.org/mozilla-central/rev/cf2ee1753201
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
Flags: in-testsuite+
Assignee | ||
Updated•6 years ago
|
Blocks: add-scriptable-editor-API-tests
You need to log in
before you can comment on or make changes to this bug.
Description
•