Closed Bug 1484119 Opened 6 years ago Closed 6 years ago

Split HTMLEditor::DeleteTableCell() for internal use

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.
Priority: -- → P3
Although this has a lot of todo_is() since this API is really broken.
nsITableEditor::DeleteTableCell() is an XPCOM method but used internally. So, HTMLEditor should implement it with non-virtual method and use it internally.
HTMLEditor::DeleteTableCellWithTransaction() does not remove <table> element even if it becomes empty only when 2 or more cell elements are selected. Therefore, we should check table size before removing a row and if it's the last row, the method should remove <table>.
Comment on attachment 9010003 [details] Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html Makoto Kato [:m_kato] has approved the revision.
Attachment #9010003 - Flags: review+
Comment on attachment 9010004 [details] Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() Makoto Kato [:m_kato] has approved the revision.
Attachment #9010004 - Flags: review+
Comment on attachment 9010005 [details] Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty Makoto Kato [:m_kato] has approved the revision.
Attachment #9010005 - Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/5e85c1d06616 part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato https://hg.mozilla.org/integration/autoland/rev/c5c4ddcd12a9 part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato https://hg.mozilla.org/integration/autoland/rev/cf2ee1753201 part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: