Closed Bug 1484120 Opened 6 years ago Closed 6 years ago

Split HTMLEditor::DeleteTableCellContents() for internal use

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Priority: -- → P3
nsITableEditor::DeleteTableCellContents() is an XPCOM method but it's used internally. So, HTMLEditor should implement it with a non-virtual method and all internal users should use the non-virtual method instead. This patch adds HTMLEditor::DeleteTableCellContentsWithTransaction() for that. Additionally, this patch renames its helper method DeleteCellContents() to DeleteAllChidlrenWithTransaction() and moves it to HTMLEditor.cpp since it can handle any element nodes.
Comment on attachment 9009997 [details] Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html Makoto Kato [:m_kato] has approved the revision.
Attachment #9009997 - Flags: review+
Comment on attachment 9010002 [details] Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() Makoto Kato [:m_kato] has approved the revision.
Attachment #9010002 - Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/1e13d82e0536 part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato https://hg.mozilla.org/integration/autoland/rev/ca674e42cbca part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: