Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 6 years ago

      No description provided.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0da4d1b2fa4b0bad38565427714963f55d485c5

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ad4018494432e7be731c731fd05f08851af6621

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 6 years ago

This patch changes a bit in HTMLEditor::DeleteTableRow() because calling
DeleteTable2() without those helper classes hits MOZ_ASSERT().

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 6 years ago

nsITableEditor::DeleteTableRow() is an XPCOM method but there are some internal
users.  So, it should be implemented as non-virtual protected method and
internal users should use it instead.

This also renames (and reimplement) HTMLEditor::DeleteTable2() since it's
really bad name and the code dispatches unnecessary "selectionchange" events.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 5 • 6 years ago

This patch renames HTMLEditor::DeleteRow() to
HTMLEditor::DeleteTableRowWithTransaction() and cleans up its implementation.

	Makoto Kato [:m_kato]
	Comment 6 • 6 years ago

Comment on attachment 9009319 [details]
Bug 1484122 - part 0: Add automated tests for nsITableEditor.deleteTableRow.html

Makoto Kato [:m_kato] has approved the revision.

	Makoto Kato [:m_kato]
	Comment 7 • 6 years ago

Comment on attachment 9009320 [details]
Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow()

Makoto Kato [:m_kato] has approved the revision.

	Makoto Kato [:m_kato]
	Comment 8 • 6 years ago

Comment on attachment 9009321 [details]
Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow()

Makoto Kato [:m_kato] has approved the revision.

	Pulsebot
	Comment 9 • 6 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/9913556f42c1
part 0: Add automated tests for nsITableEditor.deleteTableRow.html r=m_kato

	Pulsebot
	Comment 10 • 6 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/7e2fe3f19c3c
part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b240ef0f3694
part 2: Clean up HTMLEditor::DeleteRow() r=m_kato

	Eliza Balazs [:ebalazs_]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9913556f42c1
https://hg.mozilla.org/mozilla-central/rev/7e2fe3f19c3c
https://hg.mozilla.org/mozilla-central/rev/b240ef0f3694