Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 6 years ago

      No description provided.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 6 years ago

HTMLEditor::GetFirstSelectedCell() is an XPCOM method, but used internally a
lot.  Therefore, we should create a non-virtual method for internal use.

This patch creates HTMLEditor::GetFirstSelectedTableCellElement(), and it
won't return NS_SUCCESS_EDITOR_ELEMENT_NOT_FOUND since nobody needs the
value.  It's enough to check whether the result is nullptr without error for
any callers.

	Makoto Kato [:m_kato]
	Comment 3 • 6 years ago

Comment on attachment 9003398 [details]
Bug 1484128 - part 1: Create HTMLEditor::GetFirstSelectedTableCellElement() for internal use of HTMLEditor::GetFirstSelectedCell()

Makoto Kato [:m_kato] has approved the revision.

	Makoto Kato [:m_kato]
	Comment 4 • 6 years ago

Comment on attachment 9003397 [details]
Bug 1484128 - part 0: Add automated tests for nsITableEditor::GetFirstSelectedCell()

Makoto Kato [:m_kato] has approved the revision.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/7f45ff1131eb
part 0: Add automated tests for nsITableEditor::GetFirstSelectedCell() r=m_kato

	Pulsebot
	Comment 6 • 6 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/90f962c6f3df
part 1: Create HTMLEditor::GetFirstSelectedTableCellElement() for internal use of HTMLEditor::GetFirstSelectedCell() r=m_kato

	Arthur Iakab [arthur_iakab]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7f45ff1131eb
https://hg.mozilla.org/mozilla-central/rev/90f962c6f3df