nsITableEditor::GetSelectedOrParentTableElement() is of course an XPCOM method, but it's used internally. So, there should be non-virtual method. On the other hand, this API is too ugly. Returns various information but each meaning is not clear. So, result of the new non-virtual method should be simpler. This patch creates the new method as: - returns found element - takes ErrorResult to return error code. - takes optional out-param for returning if a cell is selected. Then, nsITableEditor::GetSelectedOrParentTableElement() can compute its result from them with Selection.

Comment on attachment 9008599 [details] Bug 1484133 - part 0: Add automated tests for nsITableEditor.getSelectedOrParentTableElement() Makoto Kato [:m_kato] has approved the revision.

Comment on attachment 9008600 [details] Bug 1484133 - part 1: Create non-virtual HTMLEditor::GetSelectedOrParentTableElement() Makoto Kato [:m_kato] has approved the revision.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/bcb7c4b6231b part 0: Add automated tests for nsITableEditor.getSelectedOrParentTableElement() r=m_kato https://hg.mozilla.org/integration/autoland/rev/d6556911bca9 part 1: Create non-virtual HTMLEditor::GetSelectedOrParentTableElement() r=m_kato

https://hg.mozilla.org/mozilla-central/rev/bcb7c4b6231b https://hg.mozilla.org/mozilla-central/rev/d6556911bca9