Closed Bug 1484188 Opened 6 years ago Closed 6 years ago

Update autoplay exceptions panel's title

Categories

(Core :: Audio/Video: Playback, defect)

63 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
firefox63 --- verified

People

(Reporter: gpalko, Assigned: daleharvey)

References

Details

Attachments

(1 file)

[Environment:] Nightly 63.0a1 BuildId 20180816220128 [Steps:] 1. Open about:preferences#privacy 2. Open the Autoplay Exeptions panel and inspect the title [Actual Result:] "Allowed Websites - Autoplay" is displayed [Expected Result:] "Exceptions - Autoplay" title should be displayed, as the list contains websites with both statuses(Allow/Block)
Assignee: nobody → dharvey
Attachment #9002197 - Flags: ui-review?(mliang)
Attachment #9002197 - Flags: review?(francesco.lodolo)
Comment on attachment 9002197 [details] [diff] [review] 0001-Bug-1484188-Rephrase-title-for-autoplay-exceptions-p.patch Review of attachment 9002197 [details] [diff] [review]: ----------------------------------------------------------------- Technically (from the l10n point of view) this looks good, but I think it's the wrong change. This would be the only window with that title https://transvision.mozfr.org/?recherche=Allowed+Websites+-&repo=gecko_strings&sourcelocale=en-US&locale=en-US&search_type=strings_entities
(In reply to Dale Harvey (:daleharvey) from comment #3) > It wouldnt, quite a few other prompts in that file have the same pattern, > https://transvision.mozfr.org/ > ?recherche=Exceptions&repo=gecko_strings&sourcelocale=en-US&locale=en- > US&search_type=strings_entities I stand corrected, and these are likely more recent too.
Attachment #9002197 - Flags: review?(francesco.lodolo) → review+
The title change make sense and the ui should work fine. Thanks Dale!
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc8d00a386c Rephrase title for autoplay exceptions prompt. r=flod
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Verified, that the issue is fixed on Nightly 63.0a1(20180820222055).
Status: RESOLVED → VERIFIED
Attachment #9002197 - Flags: ui-review?(mliang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: