Closed Bug 1484435 Opened 6 years ago Closed 6 years ago

Simplify MacOS sidebar tree styling

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Attached patch Simplify MacOS sidebar tree styling (obsolete) (deleted) — Splinter Review
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9002192 - Flags: review?(dao+bmo)
Blocks: 1418602
Further explanation: The 10.10+ tree styling (-moz-cellhighlighttext for selected, and HighlightText for selected, focus) is consistent with MacOS's -moz-appearance: -moz-mac-source-list-selection and -moz-mac-active-source-list-selection background colors, so we can simply remove the custom color rules for 10.10+. On the other hand, 10.9 has dark backgrounds -moz-mac-source-list-selection and -moz-mac-active-source-list-selection, so we need to set the color to white for both states.
Attached patch Simplify MacOS sidebar tree styling (obsolete) (deleted) — Splinter Review
Attachment #9002198 - Flags: review?(dao+bmo)
Attachment #9002192 - Attachment is obsolete: true
Attachment #9002192 - Flags: review?(dao+bmo)
Attached patch Simplify MacOS sidebar tree styling (obsolete) (deleted) — Splinter Review
Attachment #9002199 - Flags: review?(dao+bmo)
Attachment #9002198 - Flags: review?(dao+bmo)
Attachment #9002198 - Attachment is obsolete: true
Attachment #9002200 - Flags: review?(dao+bmo)
Attachment #9002199 - Attachment is obsolete: true
Attachment #9002199 - Flags: review?(dao+bmo)
Attachment #9002200 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: