Closed Bug 1484602 Opened 6 years ago Closed 6 years ago

Don't reuse variables in WillDeleteSelection.

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

HTMLEditRules::WillDeleteSelection is complex since some variables is reused. So I would like to clean up this to use scope and not to re-use variables for fixing bug 685799.
HTMLEditRules::WillDeleteSelection is complex since some variables is reused. So I would like to clean up this to use block scope and EditorDOMPoint before fixing bug 685799.
Comment on attachment 9002374 [details] Bug 1484602 - Don't reuse variables in WillDeleteSelection. r=masayuki Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.
Attachment #9002374 - Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/798a3e869e24 Don't reuse variables in WillDeleteSelection. r=masayuki
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: