Closed Bug 1484759 Opened 6 years ago Closed 6 years ago

Update references to "chrome://browser/content/" and "chrome://browser/content/browser.xul" in tests to use `AppConstants.BROWSER_CHROME_URL`

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Various testing utilities and individual tests are still hardcoding browser.xul. This causes tests to fail with MOZ_BROWSER_XHTML.

- https://searchfox.org/mozilla-central/search?q=%22chrome%3A%2F%2Fbrowser%2Fcontent%2F%22&path=
- https://searchfox.org/mozilla-central/search?q=%22chrome%3A%2F%2Fbrowser%2Fcontent%2Fbrowser.xul%22&path=
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
This only includes functions that seem to be using it to reference a window.
There are other instances where it's used as a generic chrome URI, and those
are left unchanged.
Comment on attachment 9002537 [details]
Bug 1484759 - Update references to browser.xul in tests to use AppConstants.BROWSER_CHROME_URL;r=Gijs

:Gijs (he/him) has approved the revision.
Attachment #9002537 - Flags: review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6003a205d723
Update references to browser.xul in tests to use AppConstants.BROWSER_CHROME_URL;r=Gijs
https://hg.mozilla.org/mozilla-central/rev/6003a205d723
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Blocks: 1501065
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: