Closed
Bug 1484946
Opened 6 years ago
Closed 6 years ago
Tree twisty in in-content pages has incorrect color when row is selected and unfocused
Categories
(Toolkit :: Themes, defect, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: ntim, Assigned: arshadkazmi42)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Reporter | |
Updated•6 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
|
Reporter | |
Comment 2•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #1)
> Is this a regression from bug 1469287?
Probably not. The twisty styling was more of less broken in the in-content pages before bug 1469287.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
Reporter | |
Comment 3•6 years ago
|
||
To fix this bug, you’ll need to add xul|treechildren::-moz-tree-twisty and xul|treechildren::-moz-tree-twisty(selected) to the respective rules here: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#783-790
You’ll also need to remove this line: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#716
Keywords: good-first-bug
|
|
Reporter | |
Comment 5•6 years ago
|
||
Yes, I've assigned the bug to you.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(ntim.bugs)
|
Assignee | |
Comment 6•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9016992 -
Attachment description: Tree twisty in content pages will show correct colors when selected and unfocussed → Tree twisty in content pages will show correct colors when selected and unfocused
|
|
||
Updated•6 years ago
|
Attachment #9016992 -
Attachment description: Tree twisty in content pages will show correct colors when selected and unfocused → Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused
|
|
Reporter | |
Updated•6 years ago
|
Attachment #9016992 -
Flags: review?(dao+bmo)
|
|
||
Updated•6 years ago
|
Attachment #9016992 -
Flags: review?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab9dfffff004
Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•