Open Bug 1485338 Opened 6 years ago Updated 2 years ago

Make XPath locator for WebDriver:FindElement and WebDriver:FindElements spec compliant

Categories

(Remote Protocol :: Marionette, enhancement, P2)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement
Points:
2

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:backlog])

Here the current definition of the spec: https://w3c.github.io/webdriver/#dfn-xpath-selector In Marionette we still use `FIRST_ORDERED_NODE_TYPE` while the spec says that `ORDERED_NODE_SNAPSHOT_TYPE` has to be used. By that there may be other follow-up changes necessary this bug has to also cover.
Priority: -- → P3
Severity: normal → S3
Blocks: 1793844
Duplicate of this bug: 1364220

Beside the above mentioned failure we also do not return the right error in case a found value cannot be returned, eg. in case of an HTML attribute we do not raise a invalid selector error but a javascript error with a cyclic object value.

I think that this is something we should fix along with the support for ShadowRoot nodes in M6. It should be a trivial fix - probably worth 2 points.

Lets discuss in the next triage meeting.

No longer blocks: 1793844
Whiteboard: [webdriver:triage]
Blocks: 1793844
Points: --- → 2
Priority: P3 → P2
Whiteboard: [webdriver:triage] → [webdriver:backlog]
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.