Brendan Dahl [:bdahl] Assignee
	Description • 6 years ago

Over in bug 1485147 we ran into more createElement calls that needed to be migrated to createXULElement. I've added logging to browser chrome tests to find the rest.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86cf2bae81e44783d1905ac0a7744a44232969f5

	Brendan Dahl [:bdahl] Assignee
	Comment 1 • 6 years ago

Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

	Brendan Dahl [:bdahl] Assignee
	Comment 2 • 6 years ago

For future reference to find more createElements from XUL:

1) Apply the patch https://hg.mozilla.org/try/rev/e15fbc016dfdb0da4862f0a7415154bfa338c023
2) use try fuzzy with "instrumentation"
3) Download all logs in folder
4) To get a list of all the unique callers run 
cat *.log | grep "CreateElement called" | sed -E 's/.*\|/LOG/g' |  sort | uniq > caller.txt
or
to get filenames only:
cat *.log | grep "CreateElement called" | sed -E 's/.*\|/LOG/g' | sed -E 's/.*"(.*)".*/\1/g' |  sort | uniq > file_only.txt

The above commands could be simplified, but it was built as I went.

	Brian Grinstead [:bgrins]
	Comment 3 • 6 years ago

Comment on attachment 9003918 [details]
Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins

Brian Grinstead [:bgrins] has approved the revision.

	Pulsebot
	Comment 4 • 6 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bc799b58c46
Use createXULElement instead of createElement in XUL docs. r=bgrins

	Arthur Iakab [arthur_iakab]
	Comment 5 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3bc799b58c46