Closed
Bug 1485577
Opened 6 years ago
Closed 6 years ago
When Firefox Nightly has no windows, link text of other applications and .webloc file open a blank page of Firefox Nightly.
Categories
(Core :: DOM: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | + | fixed |
People
(Reporter: suishouen, Assigned: Gijs)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180822221004
Steps to reproduce:
1. Launch Firefox Nightly.
2. Close all windows.
3. Open .webloc file.
Actual results:
Firefox Nightly opens a blank page and URLbar is blank.
Expected results:
Firefox Nightly should open the web page designated by the webloc file.
When Firefox Nightly has no windows, link text by other applications (e.g. Mail.app) doesn't work.
Summary: When Firefox Nightly has no windows, opening .webloc file opens a blank page of Firefox Nightly. → When Firefox Nightly has no windows, link text of other applications and .webloc file open a blank page of Firefox Nightly.
Is this bug related to Bug 1484482?
Comment 3•6 years ago
|
||
I just checked with mozregression and found this range:
9:27.36 INFO: Last good revision: 3d50f935615c9ba9179e8ab0dbb244ca65626967
9:27.36 INFO: First bad revision: 486f7f825c6bfb4b31cb76c49174f2880dd8af19
9:27.36 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3d50f935615c9ba9179e8ab0dbb244ca65626967&tochange=486f7f825c6bfb4b31cb76c49174f2880dd8af19
Which points to:
Bug 1364392 - Provide correct triggeringPrincipal to openLinkIn r=Gijs
We're hitting the newly added throw in utiltityOverlay.js (although unfortunately that message doesn't appear on the console).
When we hit loadURI here:
https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/browser/base/content/browser.js#1692
the window arguments are: [<url to load>, null, null, null]
So when this gets through to the openLinkIn call, there's no triggeringPrincipal, and so it doesn't load anything.
Blocks: 1364392
Status: UNCONFIRMED → NEW
Component: Untriaged → DOM: Security
Ever confirmed: true
Flags: needinfo?(jkt)
Keywords: regression
Product: Firefox → Core
Assignee | ||
Comment 4•6 years ago
|
||
[Tracking Requested - why for this release]:
We need to not ship this.
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox63:
--- → affected
status-firefox-esr60:
--- → unaffected
tracking-firefox63:
--- → ?
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Eiichi from comment #2)
> Is this bug related to Bug 1484482?
Based on the regression range, no, it isn't - the root causes are quite different.
Comment 6•6 years ago
|
||
Looking into this.
Comment 7•6 years ago
|
||
I created a patch however I will need someone to test it. This certainly looks like a fix for Bug 1485663 but I'm not sure if this is a fix here.
If you have time to build and test on Mac that would be great. (I requested a new loaner for the future).
Flags: needinfo?(gijskruitbosch+bugs)
Comment 8•6 years ago
|
||
Tracked for 63 since it's a recent regression.
Updated•6 years ago
|
Attachment #9003506 -
Attachment description: Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?Gijs → Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Comment 10•6 years ago
|
||
Comment on attachment 9003506 [details]
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8
Jonathan Kingston [:jkt] has approved the revision.
Attachment #9003506 -
Flags: review+
Assignee | ||
Comment 11•6 years ago
|
||
Stole this from jkt, so reflecting that in bugzilla as well.
Assignee: jkt → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 12•6 years ago
|
||
Comment on attachment 9003506 [details]
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r?jkt,Standard8
Mark Banner (:standard8) has approved the revision.
Attachment #9003506 -
Flags: review+
Comment 13•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f83d8d85c94f
Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8
Comment 14•6 years ago
|
||
Backed out for failing bc at browser/base/content/test/performance/browser_tabopen.js
Push that contains the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bbbab4206c4696bf21ae5e8b93f06bd38dd015b3
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195786732&repo=autoland&lineNumber=1969
Backout: https://hg.mozilla.org/integration/autoland/rev/9f0c56001fbffc0afe2eabffeb7b65b7139d56cd
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 15•6 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #14)
> Backed out for failing bc at
> browser/base/content/test/performance/browser_tabopen.js
>
> Push that contains the failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=bbbab4206c4696bf21ae5e8b93f06bd38dd015b3
>
> Failure log:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=195786732&repo=autoland&lineNumber=1969
>
> Backout:
> https://hg.mozilla.org/integration/autoland/rev/
> 9f0c56001fbffc0afe2eabffeb7b65b7139d56cd
This was orange prior to my patch ( https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=195799305 ) and I can't reproduce locally. Are you sure you're backing out the right change?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(apavel)
Comment 16•6 years ago
|
||
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f84d024c27b5
Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8 on a CLOSED TREE
Updated•6 years ago
|
Flags: needinfo?(apavel)
Comment 17•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•