Depending on my system colors, Firefox appears to color alternating rows of about:config. My system color scheme is light text on dark backgrounds. I've attached a screenshot. If I switch to a more usual system color scheme (like the "Windows classic" scheme), then there are no apparent alternating row colors. They're all just black text on white backgrounds. If it's relevant, I'm using the default Firefox theme. It's black in the provided screenshot because of my system colors. Switching to the bundled dark scheme doesn't help. I'm using current 64-bit nightly build (20180823100106), but I don't know when this started happening and I don't know when the last time I looked at about:config was (with proper colors), but it was probably within the last few months. I haven't tried other branches. My OS is 64-bit Windows 7.

Hi, Here are a few steps to reproduce this issue more easily: 1. Open the Firefox Browser and reach About:Config. 2. Click Yes I accept the risk. 3. Right click on Desktop and select Personalize. 4. Change the Theme to High Contrast Black while the Firefox Window is open. Expected Results: The Background of About:config should remain White with Black text. Actual Results: The Background of About:config changes to Black Backround every other row. Please note that if the user Refreshes the About:config page and Clicks Yes I accept the risk, the background will go to completely black without the above mentioned issue. Here is the regression range for this issue: INFO: Last good revision: 98d17facfe0093c4120cedd656d82b46822c1964 INFO: First bad revision: c8c488989a62c9ad8805569062c89ff74e641418 INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=98d17facfe009 3c4120cedd656d82b46822c1964&tochange=c8c488989a62c9ad8805569062c89ff74e641418

Actually: Expected Results: The Background of About:config should change to completely Black with White text. Please note that during mozregression I noticed that the Background remains completely White with no intermittent Black lines until the user reloads the page. If it's suppose to change to Completely black when changing the Windows theme to High Contrast Black then it might be a different issue.

(In reply to Rares Doghi from comment #1) > Hi, > Here are a few steps to reproduce this issue more easily: > > 1. Open the Firefox Browser and reach About:Config. > 2. Click Yes I accept the risk. > 3. Right click on Desktop and select Personalize. > 4. Change the Theme to High Contrast Black while the Firefox Window is open. > > Expected Results: > The Background of About:config should remain White with Black text. > > Actual Results: > The Background of About:config changes to Black Backround every other row. > > Please note that if the user Refreshes the About:config page and Clicks Yes > I accept the risk, the background will go to completely black without the > above mentioned issue. If colors are correct when refreshing the page, the temporary glitch sounds like a widget or layout issue.

(In reply to Dão Gottwald [::dao] from comment #3) > If colors are correct when refreshing the page, the temporary glitch sounds > like a widget or layout issue. In my case, I don't experience this. (I'm still running the same build as in my original report.) If I change my Windows color scheme while I have a tab open on about:config, then the colors used in the tab do not change. If I refresh the tab after changing the Windows scheme, then they do change. I can't find any ordering of opening/refreshing and changing my system colors that ends up with all black backgrounds.

Did you want to look into that regression range?

Seems like the issue is only a temporary glitch that can be solved by reloading/restarting the browser, I would say this is low priority.

(In reply to Tim Nguyen :ntim from comment #6) > Seems like the issue is only a temporary glitch that can be solved by > reloading/restarting the browser, I would say this is low priority. Using my normal light text on dark background scheme, I always get alternating, unreadable rows like in my screenshot. Restarting Firefox doesn't change anything.

In #c4, you said you were still running the same build as in your original report. If you use a more current Nightly build, does this still happen consistently (and/or can you reproduce based on QA's steps in #c1)?

(In reply to David Durst [:ddurst] (REO for 63) from comment #8) > In #c4, you said you were still running the same build as in your original > report. If you use a more current Nightly build, does this still happen > consistently (and/or can you reproduce based on QA's steps in #c1)? I've updated to 20180905123750 and about:config still looks like my screenshot. As far as I can tell, for me, the only steps required to reproduce my screenshot are: 1. Change the background color in the Windows system colors to black. 2. Look at about:config It appears that the rows alternate between white backgrounds and backgrounds matching the 'window background' color set in the Windows system colors. It does not appear to matter whether Firefox or an about:config tab is already open (either I was mistaken in c4 or the behavior changed since the version I was using then). I can change my system colors while about:config is visible and the alternate rows will change at the same time. I haven't ever gotten an all-black about:config mentioned in c2 by reordering changing my system colors, starting Firefox, and opening/looking at about:config.

(In reply to Fyren from comment #9) > 1. Change the background color in the Windows system colors to black. So the problem is that -moz-oddtreerow uses the window color: https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/widget/windows/nsLookAndFeel.cpp#280,284 We'll probably need a corresponding -moz-oddtreerowtext color that maps to the window text color, and set that here: https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/toolkit/themes/shared/tree.inc.css#29

That sounds sufficient to make it readable for me. It seems odd that the end result is that most people (at least on Windows, with a default background of white) will get all-white rows but anyone who has customized it will get alternating row colors.

ntim: care to try your hand at implementing #c10?

(In reply to Dão Gottwald [::dao] from comment #10) > (In reply to Fyren from comment #9) > > 1. Change the background color in the Windows system colors to black. > > So the problem is that -moz-oddtreerow uses the window color: > > https://searchfox.org/mozilla-central/rev/ > 6ef785903fee6c0b16a1eab79d722373d940fd78/widget/windows/nsLookAndFeel. > cpp#280,284 I don't think this is the problem. -moz-oddtreerow maps to the window color, but so does -moz-field which is used as the tree background. The problem here is that common.inc.css has some custom tree styling setting the background color to white (regardless of system colors), but does not take in account that odd tree rows have a system color set.

Comment on attachment 9009403 [details] Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. r?dao Dão Gottwald [::dao] has approved the revision.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fe573be562e Set custom odd tree row colors in common.css on all platforms. r=dao

Comment on attachment 9009403 [details] Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. r?dao Approval Request Comment [Feature/Bug causing the regression]: bug 1469287 [User impact if declined]: see comment 0 [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: porting a small CSS change to Windows that was already on Linux. [String changes made/needed]: n/a

Backed out changeset 9fe573be562e (Bug 1485830) for perma bc failures in browser/base/content/test/static/browser_parsable_css.js CLOSED TREE Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception,usercancel,runnable&selectedJob=199931084&revision=9fe573be562efa82e787ac3ed7e4285b8778ecf2 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199931084&repo=autoland&lineNumber=1436 Backout: https://treeherder.mozilla.org/logviewer.html#?job_id=199931084&repo=autoland&lineNumber=1436

Backout by ebalazs@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ad8d79f62b1 Backed out changeset 9fe573be562e for perma bc failures in browser/base/content/test/static/browser_parsable_css.js CLOSED TREE

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f4473d447a48 Set custom odd tree row colors in common.css on all platforms. r=dao

Comment on attachment 9009403 [details] Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. r?dao Tim, could you request the uplift on the updated patch please? Thanks

(In reply to Pascal Chevrel:pascalc from comment #22) > Comment on attachment 9009403 [details] > Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. > r?dao > > Tim, could you request the uplift on the updated patch please? Thanks The updated patch was already on the same phabricator link.

Comment on attachment 9009403 [details] Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. r?dao Thanks, uplift approved for 63 beta 8.