Closed
Bug 1486524
Opened 6 years ago
Closed 6 years ago
End xz compression of libxul and friends
Categories
(GeckoView :: General, enhancement, P1)
Tracking
(geckoview64 wontfix, firefox64 wontfix, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: snorp, Assigned: snorp)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1485045 wants to produce a "fat" AAR, which includes all supported architectures in one package. We would then rely on downstream tools to split appropriately. Those tools don't understand our placing of libraries in assets/, so we need to stop that.
Assignee | ||
Comment 1•6 years ago
|
||
I have a patch for this. https://treeherder.mozilla.org/#/jobs?repo=try&revision=3850f337ca74ae6fdb650345929c469f180c43ad&selectedJob=196173917
Fennec APK size appears to go from 33.5MB to 41.6MB.
Is this an acceptable change?
Flags: needinfo?(s.kaspari)
Flags: needinfo?(bbermes)
Comment 2•6 years ago
|
||
Is this all or nothing? Does this mean we can't have the multiarch-GeckoView-AAR without disabling this for Fennec too?
Comment 3•6 years ago
|
||
It's hard to make a call without knowing the results of "Android App Bundles" and "Dynamic Delivery". However I tend to not blocking ourselves on Fennec given that Fennec's fate is sealed.
Updated•6 years ago
|
Flags: needinfo?(s.kaspari) → needinfo?(snorp)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → snorp
Flags: needinfo?(snorp)
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Is this all or nothing? Does this mean we can't have the
> multiarch-GeckoView-AAR without disabling this for Fennec too?
I think it'll be a PITA, but could be doable. I think it depends on how much we think that size savings has helped Fennec.
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
It turns out we've probably been getting lucky loading libraries in GeckoView this whole time. The XZ libs are compressed with deflate in the AAR, and that has been getting carried over into the app APK. Apparently it works most of the time because we're unable to actually deflate xz-compressed data. According to the docs, we should be able to specify that these files are not compressed[0], but it doesn't actually work. Further, even if it did work, it's not clear to me that the final APK would carry over the decisions made in the AAR.
Apps can work around this by including the following block in the `android` section:
aaptOptions {
noCompress 'so'
}
This is not an acceptable long-term solution.
[0] https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.AaptOptions.html#com.android.build.gradle.internal.dsl.AaptOptions:noCompress
Assignee | ||
Comment 6•6 years ago
|
||
Moving to GeckoView so we prioritize it appropriately.
Component: General → GeckoView
Assignee | ||
Comment 7•6 years ago
|
||
This also uses idiomatic packaging of the native libraries, which
will allow easier downstream consumption of GeckoView.
Assignee | ||
Comment 8•6 years ago
|
||
This allows us to use the same Java code for any native platform,
enabling a "fat" AAR.
Depends on D10775
Updated•6 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Attachment #9022314 -
Attachment is obsolete: true
Updated•6 years ago
|
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bc6db0a2574
Don't use XZ compression for libs on Android r=glandium,nalexander
Comment 10•6 years ago
|
||
Backout by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e1b2b7e0c37
Backed out changeset 2bc6db0a2574 android raptor failures ona CLOSED TREE
Comment 11•6 years ago
|
||
Backed out for failing raptor android
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&selectedJob=211775539&revision=7174015fbbd584f9afa8783c1ac119ab3ac8bbf4
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211770973&repo=autoland&lineNumber=1017
Backout: https://hg.mozilla.org/integration/autoland/rev/4e1b2b7e0c37fb3fcdb6795537af53510b9308ef
Flags: needinfo?(snorp)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(snorp)
Summary: Consider ending xz compression of libxul and friends → End xz compression of libxul and friends
Comment 12•6 years ago
|
||
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e076b0054cc
Don't use XZ compression for libs on Android r=glandium,nalexander
Comment 13•6 years ago
|
||
Backed out for toolchains gradle bustages.
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=bae43dfd3700460a55f3559eabbc888975f3a3c0&tochange=a38af3c7c0e4743645888fdaf63c50101d813297&selectedJob=213155692
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213155692&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/a38af3c7c0e4743645888fdaf63c50101d813297
Flags: needinfo?(snorp)
Comment 14•6 years ago
|
||
64=wontfix because we won't want to uplift this compression change to Beta.
status-firefox64:
--- → wontfix
status-firefox65:
--- → affected
Comment 15•6 years ago
|
||
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9823c01c5580
Don't use XZ compression for libs on Android r=glandium,nalexander
Comment 16•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(snorp)
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•6 years ago
|
Version: Firefox 59 → 59 Branch
Updated•6 years ago
|
Target Milestone: Firefox 65 → mozilla65
Updated•6 years ago
|
Flags: needinfo?(bbermes)
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•