Closed
Bug 1486571
Opened 6 years ago
Closed 6 years ago
Uplift bug 1330257 to GV branch
Categories
(GeckoView :: General, enhancement, P1)
Tracking
(geckoview62blocking fixed, firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 unaffected, firefox63 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
geckoview62 | blocking | fixed |
firefox-esr52 | --- | wontfix |
firefox-esr60 | --- | wontfix |
firefox61 | --- | wontfix |
firefox62 | --- | unaffected |
firefox63 | --- | unaffected |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(8 files, 1 obsolete file)
(deleted),
patch
|
RyanVM
:
approval-mozilla-geckoview62+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
We want to uplift auto-fill (bug 1330257) to the GV-specific beta branch.
Updated•6 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → affected
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → wontfix
Priority: -- → P1
Assignee | ||
Comment 2•6 years ago
|
||
Add some tests for the Oreo auto-fill frontend, similar to the tests for the a11y auto-fill frontend. However, because these tests depend on the ViewStructure class, they require SDK 23+ to run. Differential Revision: https://phabricator.services.mozilla.com/D3810
Assignee | ||
Comment 3•6 years ago
|
||
Move the AccessibilityNodeProvider implementation under SessionAccessibility, to reduce the indent of the code. Also make all methods in SessionAccessibility.Settings static to make the code easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D3250
Assignee | ||
Comment 4•6 years ago
|
||
Make a distinction between a session being active (i.e. being visible) and it being focused. More than one session may be active at a time, but only one session is focused at a time. This means the focused session is always active, but an active session may not be focused. Also, manage setting of active/focused states in GeckoView itself, so consumers don't generally have to worry about these states. Differential Revision: https://phabricator.services.mozilla.com/D3251
Assignee | ||
Updated•6 years ago
|
Attachment #9004668 -
Attachment is obsolete: true
Assignee | ||
Comment 5•6 years ago
|
||
Make the session store event listeners inline, because it makes the code more readable, and also because auto-fill requires a pageshow listener that is always registered, so the existing pageshow listener needs to be moved elsewhere. Differential Revision: https://phabricator.services.mozilla.com/D3252
Assignee | ||
Comment 6•6 years ago
|
||
Add an auto-fill backend in GeckoViewContent.js that detects fields on the page and sends information about the fields to Java through events. Differential Revision: https://phabricator.services.mozilla.com/D3253
Assignee | ||
Comment 7•6 years ago
|
||
Add an auto-fill frontend that listens to events from Gecko. It populates accessibility nodes for input fields and sends accessibility events, in order to support auto-fill clients that use accessibility services to perform auto-fill. Differential Revision: https://phabricator.services.mozilla.com/D3254
Assignee | ||
Comment 8•6 years ago
|
||
Add some tests to AccessibilityTest to make sure we can perform auto-fill through the accessibility API. Differential Revision: https://phabricator.services.mozilla.com/D3255
Assignee | ||
Comment 9•6 years ago
|
||
Add a frontend for the Oreo auto-fill API in SessionTextInput, which processes events from Gecko and provides consumer APIs that match the Oreo auto-fill APIs. GeckoView then forwards the necessary calls to SessionTextInput. Differential Revision: https://phabricator.services.mozilla.com/D3538
Assignee | ||
Comment 10•6 years ago
|
||
Add some tests for the Oreo auto-fill frontend, similar to the tests for the a11y auto-fill frontend. However, because these tests depend on the ViewStructure class, they require SDK 23+ to run. Differential Revision: https://phabricator.services.mozilla.com/D3810
Assignee | ||
Comment 12•6 years ago
|
||
Comment on attachment 9004669 [details] [diff] [review] 1. Refactor SessionAccessibility [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: We don't want to regress auto-fill functionality User impact if declined: No auto-fill for GV Focus Fix Landed on Version: 63 Risk to taking this patch (and alternatives if risky): Slight, lots of new code String or UUID changes made by this patch: None See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #9004669 -
Flags: approval-mozilla-geckoview62?
Comment 13•6 years ago
|
||
Comment on attachment 9004669 [details] [diff] [review] 1. Refactor SessionAccessibility Needed for Focus, approved for GV62.
Attachment #9004669 -
Flags: approval-mozilla-geckoview62? → approval-mozilla-geckoview62+
Comment 14•6 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/8e2e8bea48a07f9a1bdf5089bff3ed7b4414ca4a https://hg.mozilla.org/releases/mozilla-release/rev/c75c43e86a9ea07c21484b8c92f32e714f2be633 https://hg.mozilla.org/releases/mozilla-release/rev/8f573f769a98c656cd6fd697b6ddbc62f3c02816 https://hg.mozilla.org/releases/mozilla-release/rev/765ced28c5cd0f203e3174b13eaa31fa5c2cd13f https://hg.mozilla.org/releases/mozilla-release/rev/58d3ba7d2c768625d0be4bc02fee6520805357c5 https://hg.mozilla.org/releases/mozilla-release/rev/b9ec3e3eeda232dec3614e717d47f13ce2b657b1 https://hg.mozilla.org/releases/mozilla-release/rev/0bc8dc4778efd06f54066af0a409d449c0780163 https://hg.mozilla.org/releases/mozilla-release/rev/d2939e628138e89887f1120b5841a94af7f89a9b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
You need to log in
before you can comment on or make changes to this bug.
Description
•