MozReview-Commit-ID: HZbYyg4FGwi

Comment on attachment 9004384 [details] Bug 1486631 - Add CFR, search shortcut fixes, and bug fixes to Activity Stream Ursula Sarracini (:ursula) has approved the revision.

Comment on attachment 9004384 [details] Bug 1486631 - Add CFR, search shortcut fixes, and bug fixes to Activity Stream Ed Lee :Mardak has approved the revision.

Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a89328c87888 Add CFR, search shortcut fixes, and bug fixes to Activity Stream r=Mardak,ursula

Backed out 2 changesets (bug 1486931, bug 1486631) for browser_onboarding_accessibility.js failures push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a89328c878886157edaf683b930d8ef607f69eb5&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=2417bdf57be22175c65bc710197ea0bd4d1bdce3&group_state=expanded&selectedJob=196303975&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-searchStr=Linux+x64+pgo+Mochitests+with+e10s+test-linux64-pgo%2Fopt-mochitest-browser-chrome-e10s-3+M-e10s%28bc3%29 log: https://treeherder.mozilla.org/logviewer.html#?job_id=196303975&repo=autoland backout: https://hg.mozilla.org/integration/autoland/rev/21eff49dce24897629fac41be0a5c3cdfdc502a9

Bisecting points to bug 1471389 https://github.com/mozilla/activity-stream/commit/1407877b8661fbae8e6d42c367415db99900f33e There's a bunch of Console message: [JavaScript Error: "[Exception... "File error: Not found" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://browser/content/browser.js :: onLocationChange :: line 4822" data: no]"] onLocationChange@chrome://browser/content/browser.js:4822:7 But that seems unrelated. (Appears before that commit.) I haven't looked at the code, but I'm guessing onboarding is waiting for some event that might get delayed or something in the page is preventing the "load" ??

Actually, reverting the ActivityStream.jsm json pref change for asrouter.messageProviders fixes the issue: https://github.com/mozilla/activity-stream/commit/1407877b8661fbae8e6d42c367415db99900f33e#diff-72cd6f5b7a8d1ffe4176acd491757fd0

Before the change, onboarding enabled = false always vs it becomes true, and that hides the non-router onboarding.

Yup, I'll fix this and then we'll re-export. Sorry about that

Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/332b73bd0c42 Add CFR, search shortcut fixes, and bug fixes to Activity Stream r=Mardak,ursula