We shouldn't need this anymore.

Comment on attachment 9004748 [details] [diff] [review] part 1. Stop using nsIDOMStorage in xpidl APIs Review of attachment 9004748 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay. I was doing 7 on-site interviews this week. ::: dom/base/nsGlobalWindowInner.cpp @@ +4793,4 @@ > return nullptr; > } > > + RefPtr<Storage> storage; Hmm. I guess we can rely on this function to not overwrite mSessionStorage unless it succeeds? Otherwise this would be a change in behavior. (Here and below.) I think |storage| is unused, so you can remove the declaration.

> I guess we can rely on this function to not overwrite mSessionStorage unless it succeeds? Hmm... Good point. We sort of can right now, but I would rather not. I will switch back to the old setup here.

Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/007f50309f76 part 1. Stop using nsIDOMStorage in xpidl APIs. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/55c500a8c4b3 part 2. Remove nsIDOMStorage. r=mccr8

https://hg.mozilla.org/mozilla-central/rev/007f50309f76 https://hg.mozilla.org/mozilla-central/rev/55c500a8c4b3