Closed
Bug 1486950
Opened 6 years ago
Closed 6 years ago
Intermittent browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select message based on currentDate < timestamp - Got undefined, expected [object Object]
Categories
(Firefox :: New Tab Page, defect, P5)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: andreio)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Filed by: aciure [at] mozilla.com
https://treeherder.mozilla.org/logviewer.html#?job_id=196299508&repo=autoland
https://queue.taskcluster.net/v1/task/DDQv5ZO-SQ-rOS4ZuCV2HQ/runs/0/artifacts/public/logs/live_backing.log
[task 2018-08-28T21:08:37.491Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return correct profile age creation date -
[task 2018-08-28T21:08:37.491Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by profile age created -
[task 2018-08-28T21:08:37.492Z] 21:08:37 INFO - Leaving test bound checkProfileAgeCreated
[task 2018-08-28T21:08:37.492Z] 21:08:37 INFO - Entering test bound checkProfileAgeReset
[task 2018-08-28T21:08:37.493Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return correct profile age reset -
[task 2018-08-28T21:08:37.493Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by profile age reset -
[task 2018-08-28T21:08:37.494Z] 21:08:37 INFO - Leaving test bound checkProfileAgeReset
[task 2018-08-28T21:08:37.495Z] 21:08:37 INFO - Entering test bound checkCurrentDate
[task 2018-08-28T21:08:37.508Z] 21:08:37 INFO - Buffered messages finished
[task 2018-08-28T21:08:37.509Z] 21:08:37 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select message based on currentDate < timestamp - Got undefined, expected [object Object]
[task 2018-08-28T21:08:37.513Z] 21:08:37 INFO - Stack trace:
[task 2018-08-28T21:08:37.513Z] 21:08:37 INFO - chrome://mochikit/content/browser-test.js:test_is:1304
[task 2018-08-28T21:08:37.514Z] 21:08:37 INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_targeting.js:checkCurrentDate:115
[task 2018-08-28T21:08:37.518Z] 21:08:37 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-08-28T21:08:37.519Z] 21:08:37 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-08-28T21:08:37.520Z] 21:08:37 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:990
[task 2018-08-28T21:08:37.522Z] 21:08:37 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-08-28T21:08:37.524Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select message based on currentDate > timestamp -
[task 2018-08-28T21:08:37.525Z] 21:08:37 INFO - Leaving test bound checkCurrentDate
[task 2018-08-28T21:08:37.527Z] 21:08:37 INFO - Entering test bound checkhasFxAccount
[task 2018-08-28T21:08:37.528Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return true if a fx account is set -
[task 2018-08-28T21:08:37.531Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by hasFxAccount -
[task 2018-08-28T21:08:37.532Z] 21:08:37 INFO - Leaving test bound checkhasFxAccount
[task 2018-08-28T21:08:37.534Z] 21:08:37 INFO - Entering test bound checksearchEngines
[task 2018-08-28T21:08:37.536Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | searchEngines.installed should be a non-empty array -
[task 2018-08-28T21:08:37.538Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | searchEngines.installed should be an array of visible search engines -
[task 2018-08-28T21:08:37.539Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | searchEngines.current should be a truthy string -
[task 2018-08-28T21:08:37.541Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | searchEngines.current should be the current engine name -
[task 2018-08-28T21:08:37.552Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by searchEngines.current -
[task 2018-08-28T21:08:37.552Z] 21:08:37 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by searchEngines.installed -
[task 2018-08-28T21:08:37.553Z] 21:08:37 INFO - Leaving test bound checksearchEngines
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrei.br92
Comment 1•6 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/bafc5d527be935ea8f0f72d739ff0da0ddccae9d
Fix Bug 1486950 - Increase time range for currentDate targeting mochitest
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 4•6 years ago
|
||
I see this failure occurring again:
https://treeherder.mozilla.org/logviewer.html#?job_id=198211785&repo=autoland&lineNumber=4664
[task 2018-09-08T08:32:14.821Z] 08:32:14 INFO - Console message: [JavaScript Error: "test error" {file: "chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_targeting.js" line: 78}]
[task 2018-09-08T08:32:14.822Z] 08:32:14 INFO - get foo@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_targeting.js:78:38
[task 2018-09-08T08:32:14.824Z] 08:32:14 INFO - this.mozjexl<[95]/b.Identifier@resource://gre/modules/components-utils/mozjexl.js:1:5733
[task 2018-09-08T08:32:14.825Z] 08:32:14 INFO - this.mozjexl<[94]/e.prototype.eval/<@resource://gre/modules/components-utils/mozjexl.js:1:4341
[task 2018-09-08T08:32:14.826Z] 08:32:14 INFO - promise callback*this.mozjexl<[94]/e.prototype.eval@resource://gre/modules/components-utils/mozjexl.js:1:4318
[task 2018-09-08T08:32:14.827Z] 08:32:14 INFO - this.mozjexl<[93]/d.prototype._eval/<@resource://gre/modules/components-utils/mozjexl.js:1:3696
[task 2018-09-08T08:32:14.830Z] 08:32:14 INFO - promise callback*this.mozjexl<[93]/d.prototype._eval@resource://gre/modules/components-utils/mozjexl.js:1:3634
[task 2018-09-08T08:32:14.832Z] 08:32:14 INFO - this.mozjexl<[93]/d.prototype.eval@resource://gre/modules/components-utils/mozjexl.js:1:3094
[task 2018-09-08T08:32:14.833Z] 08:32:14 INFO - eval@resource://gre/modules/components-utils/FilterExpressions.jsm:35:12
[task 2018-09-08T08:32:14.833Z] 08:32:14 INFO - isMatch@resource://activity-stream/lib/ASRouterTargeting.jsm:183:12
[task 2018-09-08T08:32:14.834Z] 08:32:14 INFO - checkMessageTargeting@resource://activity-stream/lib/ASRouterTargeting.jsm:210:22
[task 2018-09-08T08:32:14.835Z] 08:32:14 INFO - async*findMatchingMessage@resource://activity-stream/lib/ASRouterTargeting.jsm:245:15
[task 2018-09-08T08:32:14.836Z] 08:32:14 INFO - async*check_other_error_handling@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_targeting.js:79:23
[task 2018-09-08T08:32:14.838Z] 08:32:14 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1102:34
[task 2018-09-08T08:32:14.840Z] 08:32:14 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1093:16
[task 2018-09-08T08:32:14.841Z] 08:32:14 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:995:9
[task 2018-09-08T08:32:14.842Z] 08:32:14 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-09-08T08:32:14.843Z] 08:32:14 INFO -
[task 2018-09-08T08:32:14.845Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return correct profile age creation date -
[task 2018-09-08T08:32:14.852Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by profile age created -
[task 2018-09-08T08:32:14.854Z] 08:32:14 INFO - Leaving test bound checkProfileAgeCreated
[task 2018-09-08T08:32:14.855Z] 08:32:14 INFO - Entering test bound checkProfileAgeReset
[task 2018-09-08T08:32:14.856Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return correct profile age reset -
[task 2018-09-08T08:32:14.857Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select correct item by profile age reset -
[task 2018-09-08T08:32:14.859Z] 08:32:14 INFO - Leaving test bound checkProfileAgeReset
[task 2018-09-08T08:32:14.860Z] 08:32:14 INFO - Entering test bound checkCurrentDate
[task 2018-09-08T08:32:14.861Z] 08:32:14 INFO - Buffered messages finished
[task 2018-09-08T08:32:14.862Z] 08:32:14 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select message based on currentDate < timestamp - Got undefined, expected [object Object]
[task 2018-09-08T08:32:14.864Z] 08:32:14 INFO - Stack trace:
[task 2018-09-08T08:32:14.865Z] 08:32:14 INFO - chrome://mochikit/content/browser-test.js:test_is:1304
[task 2018-09-08T08:32:14.866Z] 08:32:14 INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_targeting.js:checkCurrentDate:115
[task 2018-09-08T08:32:14.866Z] 08:32:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-09-08T08:32:14.867Z] 08:32:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-09-08T08:32:14.867Z] 08:32:14 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2018-09-08T08:32:14.868Z] 08:32:14 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-09-08T08:32:14.871Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should select message based on currentDate > timestamp -
[task 2018-09-08T08:32:14.871Z] 08:32:14 INFO - Leaving test bound checkCurrentDate
[task 2018-09-08T08:32:14.872Z] 08:32:14 INFO - Entering test bound checkhasFxAccount
[task 2018-09-08T08:32:14.873Z] 08:32:14 INFO - GECKO(2510) | --DOCSHELL 0x7f4f080b8000 == 0 [pid = 2675] [id = {ea675e23-ad1a-49c2-8dae-ef8bc1b80b2c}]
[task 2018-09-08T08:32:14.874Z] 08:32:14 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_targeting.js | should return true if a fx account is set -
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•6 years ago
|
||
patch for this bug is being exported/is landing in bug 1489962
Comment hidden (Intermittent Failures Robot) |
Comment 8•6 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Iteration: --- → 64.1 (Sep 14)
Comment 9•6 years ago
|
||
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•6 years ago
|
||
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout
Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•