Closed Bug 1486960 Opened 6 years ago Closed 6 years ago

When "enable touch simulation" is enabled, make pointer:coarse and hover:none media queries evaluate true

Categories

(DevTools :: Responsive Design Mode, enhancement, P3)

Product:
DevTools
Component:
Responsive Design Mode
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: birtles, Assigned: hiro)

References

Details

(Whiteboard: [dt-q] [good first verify])

Attachments

(3 files)

Test Case
(deleted), text/html
Details
Bug 1486960 - Pretend there is only a touch screen device if touch similation is enabled on RDM. #firefox-style-system-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1486960 - Test that checks the interaction media features when touch similation is enabled on RDM. r?gl!
(deleted), text/x-phabricator-request
Details
Bug 1035774 introduces a media query that can be used to differentiate between touch devices and devices with a mouse attached. When we enable touch simulation in RDM this media query should probably act as if we have a touch screen (i.e. pointer:coarse, and hover:none too when we implement that).
(In reply to Brian Birtles (:birtles) from comment #0) > Bug 1035774 introduces a media query that can be used to differentiate > between touch devices and devices with a mouse attached. When we enable > touch simulation in RDM this media query should probably act as if we have a > touch screen (i.e. pointer:coarse, and hover:none too when we implement > that). Oh, looks like bug 1035774 covers 'hover' too.
Sounds awesome!
Summary: When "enable touch simulation" is enabled, make pointer:coarse media query evaluate true → When "enable touch simulation" is enabled, make pointer:coarse and hover:none media queries evaluate true
Whiteboard: [dt-q]
STR 1. Open the attached test case. 2. Enable touch simulation. 3. Reload the page. The items should turn green indicating that the media queries evaluate to true.
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
When the touch similation is enabled on RDM, TOUCHEVENTS_OVERRIDE_ENABLED is propagated to all descendants docShells, so that we can just query it and return PointerCapabilities::Coarse for the case.
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/858eaf4e3f00 Pretend there is only a touch screen device if touch similation is enabled on RDM. #firefox-style-system-reviewers r=emilio https://hg.mozilla.org/integration/autoland/rev/9ab9c35d407b Test that checks the interaction media features when touch similation is enabled on RDM. r=gl
https://hg.mozilla.org/mozilla-central/rev/858eaf4e3f00 https://hg.mozilla.org/mozilla-central/rev/9ab9c35d407b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Whiteboard: [dt-q] → [dt-q] [good first verify]

I can reproduce this issue following str from comment 4 using attached test case in comment 3 with Nightly 63.0a1 (2018-08-28) (64-bit) in Linux x86_64

I can verify that this issue is fixed in Latest Beta 65.0b10

Build ID         20190110221328
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

[testday-20190111]

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: