Closed Bug 1487126 Opened 6 years ago Closed 6 years ago

updatecommon.cpp compilation fails on MinGW because 3-argument wcstok cannot be found

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr60 62+ fixed
firefox63 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell
(deleted), text/x-phabricator-request
mhowell
: review+
RyanVM
: approval-mozilla-esr60+
Details
No description provided.
the Mingw Clang build failed because a 3-argument form of wcstok could not be found, despite it apparently being part of the C++ standard. Multiple forms of header files were tried. By comparison, wcstok_s is already used (e.g. widget/windows/WinUtils.cpp) and does the correct thing. So change the functions over to that one.
Comment on attachment 9004931 [details] Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell Matt Howell [:mhowell] has approved the revision.
Attachment #9004931 - Flags: review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59227967b5b5 Change uses of 3-argument wcstok to wcstok_s r=mhowell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/59227967b5b5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment on attachment 9004931 [details] Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell MingW bustage fix from bug 1481907. Approved for ESR 60.2.
Attachment #9004931 - Flags: approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: