Closed
Bug 1487397
Opened 6 years ago
Closed 6 years ago
No hover styling on trees
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | + | verified |
firefox64 | --- | verified |
People
(Reporter: mozbz, Assigned: ntim)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
dao
:
review+
pascalc
:
approval-mozilla-beta+
|
Details |
(Tested on Win7 + Win10, 63.0b1 + 64.0a1)
Visible differences:
- Tree item styling (active / hover)
- Search box padding / border
- Button styling
When DevEdition updated to 63.0b1 I lost hover styles on tree items in sidebars. While looking for a cause, I found that all the default sidebars' 'search' boxes lacked padding and a grey border, and the History Sidebar's 'View' button lacked button styling.
The necessary styles are defined in `global/in-content/common.css`, but this doesn't appear to be being applied to sidebars. A screenshot is included, showing the existing style and with manual application of 'common.css' rules. The 'Privacy Notice' item is being hovered in both shots.
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
status-firefox61:
--- → affected
status-firefox62:
--- → affected
status-firefox-esr52:
--- → affected
status-firefox-esr60:
--- → affected
Ever confirmed: true
Keywords: regression
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Affected to Library window and Edit this bookmark panel.
:ntim, could you please look into this?
Flags: needinfo?(ntim.bugs)
Summary: Sidebars missing some styling → Sidebars window missing some styling
Assignee | ||
Updated•6 years ago
|
Summary: Sidebars window missing some styling → No hover styling on trees
Comment 2•6 years ago
|
||
Page Info window also affected.
Updated•6 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Changing platform to Windows, because Linux and MacOS never had any hover states.
I'm not sure what color we can use here for hover, but the spec seems to use a semi-transparent gray.
https://firefoxux.github.io/people/shorlander/photon/Mockups/windows-10.html
OS: Unspecified → Windows
Comment 4•6 years ago
|
||
Assigning this bug to you, Tim, since this bug is tracked for 63.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Comment 5•6 years ago
|
||
Feel free to ask Dão for pointers on the hover color!
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Comment 7•6 years ago
|
||
Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao
Dão Gottwald [::dao] has approved the revision.
Attachment #9008856 -
Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d073607e0ffa
Add hover styling on trees on Windows default theme. r=dao
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao
Approval Request Comment
[Feature/Bug causing the regression]: bug 1469287
[User impact if declined]: no hover styling on trees on Windows default theme
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: small css patch
[String changes made/needed]: none
Attachment #9008856 -
Flags: approval-mozilla-beta?
Comment 10•6 years ago
|
||
I'd like it to be verified on nightly before the uplift. Brindusa could you check that once it has landed? Thanks
Flags: qe-verify+
Flags: needinfo?(brindusa.tot)
Comment 11•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 12•6 years ago
|
||
Managed to reproduce using DevEd.63.0b7, 63.0b6, 63.0b7 on win10.
Can confirm the issue is no longer present on 64.0a1 on both win10 and win7.
The hover color is set to gray for both light/dark themes.
Search box and scrollbars have on-hover effects as well.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(brindusa.tot)
Comment 13•6 years ago
|
||
Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao
Uplift approved for 63 beta 8, thanks.
Attachment #9008856 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
Flags: qe-verify+
Reporter | ||
Comment 14•6 years ago
|
||
Reporter confirming hover styling on trees looks as expected in Nightly 2018-09-19, thank you. This bug became narrower than the original description - should I file an new bug (or clone?) for the search fields and buttons missing base UI styles?
Comment 15•6 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•