Brian Grinstead [:bgrins] Assignee
	Description • 6 years ago

This can be tested by going to about:addons and applying a theme (customize mode doesn't seem to work and I'm guessing that's related to these issues).

See: https://searchfox.org/mozilla-central/source/dom/xul/nsXULElement.cpp#869-872,893-899.

Relevant stuff on XULDocument that can hopefully be hoisted up to Document or to top-level windows:

mDocLWTheme
virtual nsIDocument::DocumentTheme GetDocumentLWTheme() override;
virtual nsIDocument::DocumentTheme ThreadSafeGetDocumentLWTheme() const override;
void ResetDocumentLWTheme()

	Brian Grinstead [:bgrins] Assignee
	Comment 1 • 6 years ago

Error when opening Customize Mode:

CustomizeMode: Error entering customize mode TypeError: "lwthemeIcon is null, can't access property "style" of it"
	_updateLWThemeButtonIcon resource:///modules/CustomizeMode.jsm:170:5
	enter resource:///modules/CustomizeMode.jsm:346:7
	enter resource:///modules/CustomizeMode.jsm:266:6
	setTab resource:///modules/CustomizeMode.jsm:203:7
	enter resource:///modules/CustomizeMode.jsm:237:7
	oncommand chrome://browser/content/browser.xhtml:1:1

	Brian Grinstead [:bgrins] Assignee
	Comment 2 • 6 years ago

Note: this requires `mk_add_options 'export MOZ_BROWSER_XHTML=1'` to reproduce.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 6 years ago

Comment on attachment 9005459 [details]
Bug 1487476 - Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug

Olli Pettay [:smaug] has approved the revision.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/414403195a4e
Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug

	Raul Gurzau (:RaulG)
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/414403195a4e