Closed
Bug 1488174
Opened 6 years ago
Closed 6 years ago
Follow-up to bug 1479532 - only use Updater notification channel when not installed from Google Play
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox63 wontfix, firefox64 fixed)
RESOLVED
FIXED
Firefox 64
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(1 file)
Currently, I'm only checking the MOZ_UPDATER build define, which should exclude Beta and Release, but I should additionally be checking the installation source as well, so the notification channel only shows up on Nightly builds *not* installed from the Play Store.
Assignee | ||
Comment 1•6 years ago
|
||
That way, we only add that notification channel if the updater really is active,
i.e. not if we've been installed from the Play Store.
Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re-
moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation.
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Comment on attachment 9006163 [details]
Bug 1488174 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r?jchen
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9006163 -
Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/b9e56df24edc
Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 64 → ---
Backout by ccoroiu@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/54cd02c97ed4
Backed out changeset b9e56df24edc for fennec crashing at startup a=backout
Updated•6 years ago
|
Comment 6•6 years ago
|
||
This got backed out request from QA and the SoftVision Android developers:
https://hg.mozilla.org/mozilla-central/rev/54cd02c97ed4
Tracked in bug 1489168.
Blocks: 1489168
Flags: needinfo?(jh+bugzilla)
Assignee | ||
Comment 7•6 years ago
|
||
Hmm, it seems the ArrayList returned from Arrays.asList isn't actually extendable.
Flags: needinfo?(jh+bugzilla)
Assignee | ||
Comment 8•6 years ago
|
||
Beta and Release have MOZ_UPDATER as false, so no need to uplift.
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/e74bd1eae0db
Use UpdateServiceHelper to decide on whether to add Updater notification channel. r=jchen
Comment 10•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•