Closed
Bug 1488401
Opened 6 years ago
Closed 6 years ago
Remove the remnants of the DiskSpaceWatcher
Categories
(Core :: Hardware Abstraction Layer (HAL), enhancement)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [overhead:noted])
Attachments
(1 file)
The DiskSpaceWatcher was only ever implemented on B2G/Firefox OS and the Gonk implementation was removed a year and a half ago. Since no other implementation has been requested and the relevant code is essentially untested since the cancellation of the Firefox OS project we should remove all the related code.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 2•6 years ago
|
||
I had noticed this in https://marco-c.github.io/code-coverage-reports/#toolkit/components/diskspacewatcher, but forgot to file a bug.
Blocks: deadcode-codecoverage
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher
Andrew Sutherland [:asuth] has approved the revision.
Attachment #9006234 -
Flags: review+
|
||
Updated•6 years ago
|
Whiteboard: [overhead:noted]
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher
Olli Pettay [:smaug] has approved the revision.
Attachment #9006234 -
Flags: review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
I almost forgot, here's the try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f69d88bcd75e1041fb95f1539797ca5df7b3dbe9
|
||
Comment 6•6 years ago
|
||
Let me test this with new local storage implementation ...
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9006234 [details]
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher
Jan Varga [:janv] has approved the revision.
Attachment #9006234 -
Flags: review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3206c9b8db97
Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•