Closed Bug 1488691 Opened 6 years ago Closed 6 years ago

Trying PIP mode after an unsuccessful other crashes the app

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 63
Unspecified
Android
defect
Not set
major

Tracking

(firefox62 unaffected, firefox63 verified, firefox64 verified)

VERIFIED FIXED
Firefox 64
Tracking Status
firefox62 --- unaffected
firefox63 --- verified
firefox64 --- verified

People

(Reporter: petru, Assigned: petru)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

As per Bug 1480098 comment 2 If one try to enter PIP mode fails the next one would crash the app with the following stacktrace > java.lang.IllegalStateException: Already registered MediaControlService:MediaPlayingStatus > at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java:117) > at org.mozilla.gecko.EventDispatcher.registerUiThreadListener(EventDispatcher.java:185) > at org.mozilla.gecko.media.PictureInPictureController.tryEnteringPictureInPictureMode(PictureInPictureController.java:47) > at org.mozilla.gecko.BrowserApp.onUserLeaveHint(BrowserApp.java:1058) > at android.app.Activity.performUserLeaving(Activity.java:7422) > at android.app.Instrumentation.callActivityOnUserLeaving(Instrumentation.java:1424) > at android.app.ActivityThread.performUserLeavingActivity(ActivityThread.java:4058) > at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:4034)
Blocks: 1349523
Crash Signature: [@ java.lang.IllegalStateException: Already registered MediaControlService:MediaPlayingStatus at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java) ]
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Keywords: crash
Also, if entering PIP fails will make sure that upon restarting the activity it's orientation will match device's.
Comment on attachment 9006573 [details] Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9006573 - Flags: review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d5f43084285 Prevent registering listeners if PIP failed; r=jchen
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Flags: qe-verify+
Please request Beta approval on this when you get a chance.
Flags: needinfo?(petru.lingurar)
Verified as fixed on latest Nightly build (64.0a1 - 09/10). Device: Samsung Galaxy S8(Android 8.0.0).
Flags: qe-verify+
Comment on attachment 9006573 [details] Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani Approval Request Comment [Feature/Bug causing the regression]: Bug 1349523 [User impact if declined]: Crash on Samsung devices after enabling an accessibility service and trying PIP for the second time. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: -- [List of other uplifts needed for the feature/fix]: -- [Is the change risky?]: No [Why is the change risky/not risky?]: Small code change with very little impact. [String changes made/needed]: --
Flags: needinfo?(petru.lingurar)
Attachment #9006573 - Flags: approval-mozilla-beta?
Comment on attachment 9006573 [details] Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani Crash fix on Android O with a minimal patch, uplift approved for 63 beta 5.
Attachment #9006573 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I'd like QE to verify the fix on Beta on Oreo, thanks.
Flags: qe-verify+
Verified as fixed on latest Beta build - 63.0b5. Device: Samsung Galaxy S8(Android 8.0.0). Following the steps provided by Petru, the app doesn't crash.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: