Closed
Bug 1488691
Opened 6 years ago
Closed 6 years ago
Trying PIP mode after an unsuccessful other crashes the app
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox62 unaffected, firefox63 verified, firefox64 verified)
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox62 | --- | unaffected |
firefox63 | --- | verified |
firefox64 | --- | verified |
People
(Reporter: petru, Assigned: petru)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
jchen
:
review+
pascalc
:
approval-mozilla-beta+
|
Details |
As per Bug 1480098 comment 2
If one try to enter PIP mode fails the next one would crash the app with the following stacktrace
> java.lang.IllegalStateException: Already registered MediaControlService:MediaPlayingStatus
> at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java:117)
> at org.mozilla.gecko.EventDispatcher.registerUiThreadListener(EventDispatcher.java:185)
> at org.mozilla.gecko.media.PictureInPictureController.tryEnteringPictureInPictureMode(PictureInPictureController.java:47)
> at org.mozilla.gecko.BrowserApp.onUserLeaveHint(BrowserApp.java:1058)
> at android.app.Activity.performUserLeaving(Activity.java:7422)
> at android.app.Instrumentation.callActivityOnUserLeaving(Instrumentation.java:1424)
> at android.app.ActivityThread.performUserLeavingActivity(ActivityThread.java:4058)
> at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:4034)
Updated•6 years ago
|
Crash Signature: [@ java.lang.IllegalStateException: Already registered MediaControlService:MediaPlayingStatus at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java) ]
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Also, if entering PIP fails will make sure that upon restarting the activity
it's orientation will match device's.
Comment 2•6 years ago
|
||
Comment on attachment 9006573 [details]
Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9006573 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d5f43084285
Prevent registering listeners if PIP failed; r=jchen
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee | ||
Updated•6 years ago
|
Flags: qe-verify+
Comment 5•6 years ago
|
||
Please request Beta approval on this when you get a chance.
Comment 6•6 years ago
|
||
Verified as fixed on latest Nightly build (64.0a1 - 09/10).
Device: Samsung Galaxy S8(Android 8.0.0).
Flags: qe-verify+
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9006573 [details]
Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1349523
[User impact if declined]: Crash on Samsung devices after enabling an accessibility service and trying PIP for the second time.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small code change with very little impact.
[String changes made/needed]: --
Flags: needinfo?(petru.lingurar)
Attachment #9006573 -
Flags: approval-mozilla-beta?
Comment 8•6 years ago
|
||
Comment on attachment 9006573 [details]
Bug 1488691 - Prevent registering listeners if PIP failed; r?sdaswani
Crash fix on Android O with a minimal patch, uplift approved for 63 beta 5.
Attachment #9006573 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•6 years ago
|
||
bugherder uplift |
Comment 11•6 years ago
|
||
Verified as fixed on latest Beta build - 63.0b5.
Device: Samsung Galaxy S8(Android 8.0.0). Following the steps provided by Petru, the app doesn't crash.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Flags: qe-verify+
Updated•6 years ago
|
Keywords: regression
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•