Closed
Bug 1488759
Opened 6 years ago
Closed 6 years ago
BinaryArith ICs missing in gdocs
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: tcampbell, Assigned: mgaudet)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
One item from https://bugzilla.mozilla.org/show_bug.cgi?id=1488435#c3 is that a bunch of binary arithmetic ICs doing bit operations on >32-bit integers are failing to attach.
|
Reporter | |
Comment 2•6 years ago
|
||
Examples in CacheIR logs
> {
> "name":"BinaryArith",
> "file":"https://www.google.com/js/bg/.js line 1 > Function",
> "mode":0,
> "line":3,
> "column":4733,
> "pc":"158e63ccab1",
> "op":"ursh",
> "rhs":{
> "type":"int32",
> "value":11
> },
> "lhs":{
> "type":"number",
> "value":"54772703898"
> }
> },
> {
> "name":"BinaryArith",
> "file":"https://www.google.com/js/bg/.js line 1 > Function",
> "mode":0,
> "line":3,
> "column":4733,
> "pc":"158e63ccab7",
> "op":"bitxor",
> "rhs":{
> "type":"number",
> "value":"54772703898"
> },
> "lhs":{
> "type":"number",
> "value":"2890608493"
> }
> },
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Flags: needinfo?(mgaudet)
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D5060
|
||
Updated•6 years ago
|
Attachment #9006644 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #9006645 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Reporter | |
Comment 7•6 years ago
|
||
Comment on attachment 9006699 [details]
Bug 1488759 - Add IC support for bitwise ops on all Number x Number combinations r=tcampbell
Ted Campbell [:tcampbell] has approved the revision.
Attachment #9006699 -
Flags: review+
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f6e36e7d6d6
Add IC support for bitwise ops on all Number x Number combinations r=tcampbell
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [qf:p1:f64]
|
||
Updated•3 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1:f64]
You need to log in
before you can comment on or make changes to this bug.
Description
•