Closed
Bug 1488899
Opened 6 years ago
Closed 6 years ago
Integration Tests: Tests are failing in tps step when trying to use the profile
Categories
(Firefox :: Sync, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: isabel_rios, Assigned: markh)
References
Details
Attachments
(2 files)
All integration tests are failing due to this error:
```tps.py 33 INFO Using profile at: /var/folder/md/29mfzzms0wn_1ljqddc61y840000gn/T/tmpAtuNJX.mozrunner
FAILED```
Complete log from Jenkins attached.
It is reproducible locally.
Reporter | ||
Comment 1•6 years ago
|
||
This started to happen yesterday afternoon. Dave, any idea about changes that could have affected the tests?
Thanks!
Flags: needinfo?(dave.hunt)
Comment 2•6 years ago
|
||
The Firefox log contains:
JavaScript error: chrome://browser/content/browser-tabsintitlebar.js, line 302: TypeError: this._menuObserver is undefined, can't access property "disconnect" of it
JavaScript error: resource://gre/modules/ExtensionParent.jsm, line 1100: TypeError: this.chromeShell is null, can't access property "document" of it
JavaScript error: resource:///modules/aboutpages/AboutPrivateBrowsingHandler.jsm, line 26: TypeError: this.pageListener is undefined, can't access property "removeMessageListener" of it
At first it appears this is not related to a change in Firefox as both the last good and first bad builds are from revision bade35bc346f3bc1f5e8b59d3d49c7a1ba28166c.
Comment 3•6 years ago
|
||
The first failing build downloaded a newer version of tps.xpi:
Downloading from: https://queue.taskcluster.net/v1/task/J9stvaH-QbWU1tK0jL2sOQ/artifacts/public/tps.xpi
Comment 4•6 years ago
|
||
It could be because we're downloading a TPS extension based off mozilla-central, but using nightly builds. This means there could be some time between a change to the extension and the next nightly build.
Flags: needinfo?(dave.hunt)
Comment 5•6 years ago
|
||
The last good TPS extension was built from revision cd72be2928ea, and the first bad was built from c3734e0f634e. I worked this out from the task ids in the console logs for the TPS, and matched these with the recent builds of the extension in Treeherder. This makes the regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cd72be2928ea&tochange=c3734e0f634e
From this, it looks like TPS is now a web extension (bug 1451527). I suspect we need to update the sync integration test harness to match the changes to the TPS test harness. Perhaps :tcsc can advise?
Flags: needinfo?(tchiovoloni)
Comment 6•6 years ago
|
||
Thanks to all, note I am using a Windows RM-1073 stuck in stating running Windows 8.1, yet when reviewing logs states Explorer 11, along with this syncing to an older LapTop using Windows 8.1 and connects to Infrastructure, and Debugging Explorer, Firefox running in background. Chrome,AOL and Yahoo are disabled and Microsoft 2003 and 2007 versions are loaded, Office 2010 I have yet to run my disc yet the areas City Facility's have used Private Key and upgraded. IE:Texas Work Force has Microsoft Office 2017 for training, as it is an siphoning kiosk when asked to enter an Email address. Now I personally updated the City of San Antonio Housing Authorities Microsoft,Adobe Flash Players and Chrome Browsers as well as several City of San Antonio Public Library's which run different combinations of equipment from all Apple Desktops, Dell only Desktop and Laptops, and Microsoft and Apple Desktops back to back depending on what side of town you visit. With Samsung and LG device's there is no issue of interpolation between my accounts. Devices plugged and played as well as connected to Network Wifi with no issue, as well as Encrypted BlueTooth Only for transfer of information. The Android devices I used run Developer Mode with encryption on device and SD card. This device is not being allowed to download Developer Mode, Chrome, Play store Apps or Firefox.
Comment 7•6 years ago
|
||
I've tried changing the harness to use preferences instead of command line arguments, but Firefox is still failing to launch when the extension is present in the profile. See comment 2 for the logs from Firefox.
Comment 8•6 years ago
|
||
(In reply to Mr. Jacob James Davila from comment #6)
> Thanks to all, note I am using a Windows RM-1073 stuck in stating running
> Windows 8.1, yet when reviewing logs states Explorer 11, along with this
> syncing to an older LapTop using Windows 8.1 and connects to Infrastructure,
> and Debugging Explorer, Firefox running in background. Chrome,AOL and Yahoo
> are disabled and Microsoft 2003 and 2007 versions are loaded, Office 2010 I
> have yet to run my disc yet the areas City Facility's have used Private Key
> and upgraded. IE:Texas Work Force has Microsoft Office 2017 for training, as
> it is an siphoning kiosk when asked to enter an Email address. Now I
> personally updated the City of San Antonio Housing Authorities
> Microsoft,Adobe Flash Players and Chrome Browsers as well as several City of
> San Antonio Public Library's which run different combinations of equipment
> from all Apple Desktops, Dell only Desktop and Laptops, and Microsoft and
> Apple Desktops back to back depending on what side of town you visit. With
> Samsung and LG device's there is no issue of interpolation between my
> accounts. Devices plugged and played as well as connected to Network Wifi
> with no issue, as well as Encrypted BlueTooth Only for transfer of
> information. The Android devices I used run Developer Mode with encryption
> on device and SD card. This device is not being allowed to download
> Developer Mode, Chrome, Play store Apps or Firefox.
You comment appears unrelated to this bug. Did you mean to comment on another issue?
Reporter | ||
Comment 9•6 years ago
|
||
Thanks Dave for your help debugging this!
Comment 10•6 years ago
|
||
Hrm, sorry about this, we changed TPS to be a webextension, and I meant to CC davehunt on it but guess I forgot (very sorry).
That said, if you changed the arguments to be passed as prefs, that should be all you need to do.
Leaving the needinfo so I know to dig into this.
Comment 11•6 years ago
|
||
Here's a summary of my findings so far based on the latest Nightly and tps.xpi builds (after local modifications to use TPS preferences instead of command line options):
When I run the sync integration tests (without cache), https://archive.mozilla.org/pub/firefox/nightly/2018/09/2018-09-10-22-01-42-mozilla-central/firefox-64.0a1.en-US.mac.dmg is downloaded, along with https://queue.taskcluster.net/v1/task/c0doUuM5Seawyjk99a9KcA/artifacts/public/tps.xpi.
The harness creates a profile with the tps.xpi and attempts to launch Firefox using the profile. I see no Firefox launch, and the test fails because the tps log file is not present. The Firefox log file is empty.
Attempting to run Firefox from the command line with the same profile, I see Firefox trying to launch and then closes. The output in the console is:
> JavaScript error: jar:file:///private/var/folders/wz/3v_j7g2n2zx_q6qs8g7vmyg00000gn/T/pytest-of-dhunt/pytest-67/firefox0/Firefox%20Nightly.app/Contents/Resources/browser/omni.ja!/components/nsBrowserGlue.js, line 974: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIIdleService.removeIdleObserver]
Further attempts fail in the same way, but with no console output.
Opening the profile in finder I see tps@mozilla.org.xpi in the extensions directory. After removing it from this directory and repeating the attempt to launch Firefox from the console, Firefox successfully launches. The console output states that it's unable to load script: jar:file:///var/folders/wz/3v_j7g2n2zx_q6qs8g7vmyg00000gn/T/tmpid9FiF.mozrunner/extensions/tps@mozilla.org.xpi!/api.js (understandable, as I have removed it).
After closing Firefox, restoring tps@mozilla.org.xpi to the extensions directory, and repeating the attempt to launch Firefox results in a successful launch of Firefox with the TPS extension listed in about:addons.
I wonder if the addon is somehow conflicting with some first-launch logic in Firefox?
Reporter | ||
Comment 12•6 years ago
|
||
Hi, Dave, Tom, any news about this? Any workaround for the SyncIntegration tests? they are still disabled...
Thanks!
Flags: needinfo?(dave.hunt)
QA Contact: sarentz
Updated•6 years ago
|
QA Contact: sarentz
Comment 13•6 years ago
|
||
Thom and I spoke about this last week. I believe he's going to raise this to see if we can free up some time to work on it.
Flags: needinfo?(dave.hunt)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to Dave Hunt [:davehunt] ⌚️UTC+1 from comment #7)
> I've tried changing the harness to use preferences instead of command line
> arguments, but Firefox is still failing to launch when the extension is
> present in the profile. See comment 2 for the logs from Firefox.
This was tricky to track down as it was somewhat intermittent. Firefox is silently being killed immediately after launch by https://searchfox.org/mozilla-central/rev/3a54520d8d2319a4116866371ed3d9ed2ec0cc2b/services/sync/tps/extensions/tps/api.js#47. For some reason I don't understand, the import of FormAutofillSync.jsm at the top of tps.jsm was failing with some obscure error which was probably timing related. tps.jsm doesn't even use that, so :shrug.
I also discovered many other issues with tps being flakey and I think I've fixed most of them - however, there were some addon failures which look like are demonstrating a real bug - so I disabled these tests and opened bug 1498974.
Assignee: nobody → markh
Status: NEW → ASSIGNED
tracking-fxios:
+ → ---
Component: Build & Test → Sync
Flags: needinfo?(tchiovoloni)
OS: iOS → All
Priority: -- → P1
Product: Firefox for iOS → Firefox
Hardware: Other → Desktop
Assignee | ||
Comment 15•6 years ago
|
||
Bug 1498974 - Part 2: Remove old async support, more effort to prevent Syncs during TPS and fix imports. r?tcsc
Updated•6 years ago
|
Attachment #9017068 -
Attachment description: Bug 1488899 - Part 1: allow individial tests to be disabled and disable some addon tests. r?tcsc → Bug 1488899 - Get TPS working. r?tcsc
Comment 16•6 years ago
|
||
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5622861eb245
Get TPS working. r=tcsc
Comment 17•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•