Closed
Bug 1488915
Opened 6 years ago
Closed 6 years ago
Migrate toolbox-process-window.xul to HTML
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: bgrins, Assigned: Honza)
References
Details
Attachments
(1 file)
Spinning this out from a discussion with Honza:
https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-process-window.xul
- I believe this is doable. We can port the <commandset> in it and the toolbox-window to just hook up key shortcuts directly, and I'd also need to look more closely at mainPopupSet but AFAICT that's unused now.
- We can probably also remove a number of the scripts loaded at the top.
- We could either `hg mv toolbox-process-window.xul toolbox-process-window.xhtml` and then keep default ns as XUL, as we do with browser.xhtml, or porting most of the markup to HTML and keeping XUL only as needed.
- We may consider porting the XULStore data from the old path the to new (so size/location info stays persisted).
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → odvarko
Assignee | ||
Comment 1•6 years ago
|
||
Thanks for the report Brian, let's try to remove a bit more XUL!
I am attaching first try for review.
The module would deserve some code cleanup, but we can do it after...
Honza
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Ah, also, we might want to try to remove some of the scripts.
Honza
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 9007233 [details]
Bug 1488915 - Migrate toolbox-process-window.xul to HTML; r=bgrins
Brian Grinstead [:bgrins] has approved the revision.
Attachment #9007233 -
Flags: review+
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50eedf887f96
Migrate toolbox-process-window.xul to HTML; r=bgrins
Comment 8•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•