Screenreader check for browser.xhtml
Categories
(Firefox :: Disability Access, task, P3)
Tracking
()
People
(Reporter: bgrins, Unassigned)
References
Details
Reporter | ||
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Reporter | ||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Updated•6 years ago
|
Reporter | ||
Comment 9•6 years ago
|
||
Reporter | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Comment 12•6 years ago
|
||
Hi Marco and Jamie, we are getting much more green now for browser.xhtml so I was hoping one of you could do another screenreader test. Here's an (ongoing) try push with it enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4838e76851e37e53553e31de4f70c9cbcb7fd987.
Reporter | ||
Comment 13•6 years ago
|
||
I don't know why this try push only has OSX builds triggered - it's the same syntax I've used before to include windows and linux. Let me try again, but in the meantime it can be built locally with mk_add_options 'export MOZ_BROWSER_XHTML=1'
in the mozconfig file.
Reporter | ||
Comment 14•6 years ago
|
||
OK, still not sure what's going on with those decision tasks, but here's a push that does have Windows binaries: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cda6fb8d7df5b60b91301c2b7cdb75bc95c5d4d
Comment 15•6 years ago
|
||
As far as I can see this is still XUL content (including XUL window document element) hosted inside browser.xhtml. As long as document type is the only change, I wouldn't expect major a11y regressions. A11y code has some code paths where IsXULDocument() is used, which returns false now I assume, but those doens't seem relevant or at least critical.
Anyway, I played a bit with VoiceOver, and didn't notice anything suspicious. Marco or Jamie will be in a better spot for sure to make that check. So, If Marco or Jamie notice anything unusual on either platform, then IsXULDocument() places should be inspected, otherwise it's good to enable by default from a11y perspective I'd say.
Reporter | ||
Comment 17•6 years ago
|
||
Jamie, here's a recent try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a84a0b1d89f1e767824498dc6958669ac99a256b. I expect this is all working correctly now but could you do a quick sanity check to make sure stuff like https://bugzilla.mozilla.org/show_bug.cgi?id=1488918#c6 is fixed?
Reporter | ||
Updated•6 years ago
|
Comment 18•6 years ago
|
||
I did some whirlwind and not very scientific testing of things like: menu bar, alt+d, control+l, control+t, control+w, visiting a URL, alt+leftArrow (Back), alt+rightArrow (Forward), toolbar keyboard navigation, opening/navigating/closing the Firefox hamburger menu, control+shift+j (browser console), activating various context menus with the applications key, control+o. All seemed to work as expected.
Reporter | ||
Comment 19•6 years ago
|
||
(In reply to James Teh [:Jamie] from comment #18)
I did some whirlwind and not very scientific testing of things like: menu bar, alt+d, control+l, control+t, control+w, visiting a URL, alt+leftArrow (Back), alt+rightArrow (Forward), toolbar keyboard navigation, opening/navigating/closing the Firefox hamburger menu, control+shift+j (browser console), activating various context menus with the applications key, control+o. All seemed to work as expected.
Thank you Jamie!
Description
•