(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Description • 6 years ago

If GV loads a page with a11y initially on, auto-fill will initialize. However, we will then crash if a11y is subsequently turned off.

	(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Comment 1 • 6 years ago

Don't send window changed event if a11y has been turned off in the mean
time.

	Eitan Isaacson [:eeejay]
	Comment 2 • 6 years ago

Comment on attachment 9007026 [details]
Bug 1489250 - Don't send window changed event if a11y is off; r?eeejay

Eitan Isaacson [:eeejay] has approved the revision.

	Pulsebot
	Comment 3 • 6 years ago

Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a0494308f1f
Don't send window changed event if a11y is off; r=eeejay

	Chris Peterson [:cpeterson]
	Comment 4 • 6 years ago

[Tracking Requested - why for this release]:

Jim, do we need to uplift this crash fix to Fennec 62? Or does this autofill code only affect GV?

	(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Comment 5 • 6 years ago

Yeah we should uplift it to Fennec 63.

	Chris Peterson [:cpeterson]
	Comment 6 • 6 years ago

[Tracking Requested - why for this release]:

This is a regression in Fennec (and GeckoView) 62.

Does this crash necessitate a 62.0.1 dot release? Or being a ride-along fix if there is a dot release for another bug?

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8a0494308f1f

	Pascal Chevrel:pascalc (PTO until August 21)
	Comment 8 • 6 years ago

(In reply to Jim Chen [:jchen] [:darchons] from comment #5)
> Yeah we should uplift it to Fennec 63.

Can you prepare the patch and request the uplift please? Thanks

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 6 years ago

Bug 1330257 never got uplifted to Fennec 62, so I'm having a hard time understanding why it's marked as affected.

	(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Comment 10 • 6 years ago

Yeah it should GV 62 and Fennec 63 (but not Fennec 62)

	(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Comment 11 • 6 years ago

Comment on attachment 9007026 [details]
Bug 1489250 - Don't send window changed event if a11y is off; r?eeejay

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1330257
[User impact if declined]: Rare crash when using auto-fill and turning a11y on/off
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple crash fix
[String changes made/needed]: None

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 6 years ago

FYI, this grafts cleanly to Beta and the GV62 relbranch as-landed. Just needs approval requests.

	(inactive) Jim Chen [:jchen] [:darchons] Assignee
	Comment 13 • 6 years ago

Comment on attachment 9007026 [details]
Bug 1489250 - Don't send window changed event if a11y is off; r?eeejay

[Approval Request Comment]

If this is not a sec:{high,crit} bug, please state case for consideration: Crash fix

User impact if declined: Rare crash when using auto-fill and turning a11y on/off

Fix Landed on Version: 64

Risk to taking this patch (and alternatives if risky): No risk; simple crash fix

String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/Uplift_rules for more info.

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 6 years ago

Comment on attachment 9007026 [details]
Bug 1489250 - Don't send window changed event if a11y is off; r?eeejay

Approved for Fennec 63.0b5 and GV62.

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 6 years ago
uplift

GECKOVIEW_62_RELBRANCH:
https://hg.mozilla.org/releases/mozilla-release/rev/ece2f6547002

	Chris Peterson [:cpeterson]
	Comment 16 • 6 years ago

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> Bug 1330257 never got uplifted to Fennec 62, so I'm having a hard time
> understanding why it's marked as affected.

OK. I wasn't sure if Fennec 62 was affected. (comment 4)

	Daniel Varga [:dvarga]
	Comment 17 • 6 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/c18e69fdab06

	Sorina Florean [:sflorean]
	Comment 18 • 6 years ago

Tested with OnePlus 5T(Android 8.1.0) on 63.0b5 and we couldn't reproduce the crash following the information/steps provided. So verified as fixed.