Closed
Bug 1489252
Opened 6 years ago
Closed 6 years ago
Add telemetry probes to report how often fastblock blocks certain analytics providers
Categories
(Core :: Networking: HTTP, enhancement, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(5 files)
(deleted),
application/json
|
Details | |
(deleted),
text/x-phabricator-request
|
baku
:
review+
pascalc
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
mayhemer
:
review+
baku
:
review+
chutten
:
review+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
text/plain
|
liuche
:
review+
|
Details |
We would like to measure something like the percentage of pages which have analytics resources from certain providers where fastblock has decided to block them, based on the domain name.
More info to be added here...
Comment 1•6 years ago
|
||
Attached are the counts of the top hostnames in the Analytics category of the Disconnect list. The counts given are the number of first-party domains on which a URL loaded from one of those hostnames would have been classified by Tracking Protection. The counts are over the top 1 million homepages in June 2018.
Assignee | ||
Comment 2•6 years ago
|
||
We decided to use the top-10 from this list.
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D5295
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9007316 -
Attachment mime type: text/plain → image/png
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9007344 [details]
Data Review Request
Francois thought chutten could review this since I asked for his review on the patch as well.
Attachment #9007344 -
Flags: review?(francois) → review?(chutten)
Assignee | ||
Updated•6 years ago
|
Attachment #9007344 -
Attachment mime type: text/markdown → text/plain
Comment 8•6 years ago
|
||
Comment on attachment 9007344 [details]
Data Review Request
Redirecting to :liuche since I gave technical review.
Attachment #9007344 -
Flags: review?(chutten) → review?(liuche)
Comment 9•6 years ago
|
||
Comment on attachment 9007344 [details]
Data Review Request
data-review+ only
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, this is collected as part of Histograms.json
Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
Yes, part of Firefox data controls
If the request is for permanent data collection, is there someone who will monitor the data over time?
Not permament
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2
Is the data collection request for default-on or default-off?
Pre-release channels default-on, and Beta 63 population
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
Is the data collection covered by the existing Firefox privacy notice?
Yes, looking at blocking in top 10 analytics providers, number of pages browsed
Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
No, expires in 67
Attachment #9007344 -
Flags: review?(liuche) → review+
Comment 10•6 years ago
|
||
Comment on attachment 9007314 [details]
Bug 1489252 - Part 1: Move browser.fastblock.enabled to StaticPrefList.h; r=baku
Andrea Marchesini [:baku] has approved the revision.
Attachment #9007314 -
Flags: review+
Updated•6 years ago
|
Attachment #9007315 -
Attachment description: Bug 1489252 - Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer data-r=francois → Bug 1489252 - Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer data-r=chutten
Comment 11•6 years ago
|
||
Comment on attachment 9007315 [details]
Bug 1489252 - Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer data-r=chutten
Honza Bambas (:mayhemer) has approved the revision.
Attachment #9007315 -
Flags: review+
Comment 12•6 years ago
|
||
Comment on attachment 9007315 [details]
Bug 1489252 - Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer data-r=chutten
Andrea Marchesini [:baku] has approved the revision.
Attachment #9007315 -
Flags: review+
Comment 13•6 years ago
|
||
Comment on attachment 9007315 [details]
Bug 1489252 - Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer data-r=chutten
Chris H-C :chutten has approved the revision.
Attachment #9007315 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3de1fff3b24f
Part 1: Move browser.fastblock.enabled to StaticPrefList.h; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/f00de8e1435f
Part 2: Add a telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock for top-level documents; r=baku,mayhemer,chutten data-r=liuche
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3de1fff3b24f
https://hg.mozilla.org/mozilla-central/rev/f00de8e1435f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 16•6 years ago
|
||
Can we uplift this to beta?
Assignee | ||
Comment 17•6 years ago
|
||
Comment on attachment 9007314 [details]
Bug 1489252 - Part 1: Move browser.fastblock.enabled to StaticPrefList.h; r=baku
Approval Request Comment
[Feature/Bug causing the regression]: Not a regression
[User impact if declined]: This is a new telemetry probe
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: None
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not that risky
[Why is the change risky/not risky?]: This is a telemetry probe that will only kick in for users who have fastblock enabled. In beta, fastblock is disabled for everyone except for the population under the shield study.
[String changes made/needed]: None
Attachment #9007314 -
Flags: approval-mozilla-beta?
Comment 18•6 years ago
|
||
Comment on attachment 9007314 [details]
Bug 1489252 - Part 1: Move browser.fastblock.enabled to StaticPrefList.h; r=baku
Useful for our shield study in Beta, approved for 63 Beta 8, thanks.
Attachment #9007314 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 19•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/d8201405128b
https://hg.mozilla.org/releases/mozilla-beta/rev/b48481b32497
status-firefox63:
--- → fixed
Comment 20•6 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•