Closed Bug 1489253 Opened 6 years ago Closed 3 years ago

Delete/open emails in Gmail is slower than Chrome

Categories

(Core :: JavaScript Engine: JIT, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME
Performance Impact medium
Tracking Status
firefox67 --- affected

People

(Reporter: Harald, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached file Profile-20180904T175305.json.zip (deleted) —
STR: - Login to the new gmail design - Enable Preview Pane in Advanced settings - Select an email - Delete a bunch of emails using Shift-3. Firefox has 200-500ms hangs when opening/deleted emails. Chrome is near-instant. https://perfht.ml/2LZV4Hi (OSX, WebRender) Attached Chrome performance profile. This might be network/service-worker related, as the JS times look comparable.
Hey - mstange, jrmuizel and I looked at this profile today. What appears to be going on in the profile is that we never get to Ion - we're stuck in the Baseline JIT the whole time. Is this a problem on our end, or do we need to talk to the GMail team to make their hot JS code more Ion-friendly?
Component: Desktop → JavaScript Engine: JIT
Flags: needinfo?(tcampbell)
Product: Tech Evangelism → Core
Whiteboard: [qf] → [qf:p1:f64]
Just two possible avenues: 1) We could reach out to the Closure Library, the underlying framework dependency, and ask for a benchmark. 2) Could this also be a side effect of the Closure Compiler's rewrites and dead-code elimination?
Assignee: nobody → tcampbell
Assignee: tcampbell → nobody
Whiteboard: [qf:p1:f64] → [qf:p2]
Flags: needinfo?(tcampbell)

Looking at the profile it seems that we definitely have a bug in the JS engine.
The hottest function (58.5 ms) seems to be only running (self-time) under the interpreter for 58.5 ms.

This should not happen, and we should do something about it. Usually the reason being that one opcode is not implemented.

As for running in IonMonkey it is suspicious that none of the functions are running under Ion with self-time as large as 10s of ms per action.

Priority: -- → P2

In the STR,

  • Enable Preview Pane in Advanced settings

This doesn't exist anymore in Advanced settings, but it has been moved to General. which offers a choice to select the time it takes to mark a conversation as read. From immediately to never.

Testing the deletion with shift-3 works well and is instant.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Performance Impact: --- → P2
Whiteboard: [qf:p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: