Closed
Bug 1489282
Opened 6 years ago
Closed 6 years ago
Create a preferences module that can be used across all components
Categories
(Firefox :: Address Bar, enhancement, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
It would be useful to have a preferences module that can be used in the model, view, and controller as necessary.
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
This factors out the `Prefs` object from UnifiedComplete.js into UrlbarPreferences.jsm and makes required changes so it's not tied to consts and other identifiers local to UnifiedComplete.js. It adds another new module, UrlbarUtils.jsm, for storing consts that both UrlbarPreferences and UnifiedComplete use.
In order to preserve blame as much as possible, I used `hg cp` to copy UnifiedComplete.js to UrlbarPreferences.jsm, and then I removed all the non-Prefs code before making other changes, so this patch looks bigger than it really is. (Maybe I wasn't actually so successful in preserving a lot of blame.)
Comment 2•6 years ago
|
||
Comment on attachment 9008268 [details]
Bug 1489282 - Create a UrlbarPreferences module that can be used across all urlbar components
Marco Bonardo [::mak] has approved the revision.
Attachment #9008268 -
Flags: review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67f7bbfb61c2
Create a UrlbarPreferences module that can be used across all urlbar components r=mak
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•