Closed Bug 1489509 Opened 6 years ago Closed 6 years ago

No way to know the public parent of a Phabricator revision

Categories

(Conduit :: General, enhancement)

Product:
Conduit
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: marco, Unassigned)

References

Details

(Keywords: conduit-triaged)

Right now we can retrieve the first base vcs revision of a Phabricator revision, but this is not always a public revision. In MozReview we had access to all public and non-public revisions, so we were always able to apply patches. See also bug 1366401 comment 7.
The first step here is to see how frequent it is. If it is not frequent, we can ignore it. If it is frequent, we should ask developers why they are doing this and figure out if we want to support their use case. Bastien, when you fix https://github.com/mozilla/release-services/issues/1446, can you raise a specific exception for the case where the parent is not available, so we can see how frequent it is? After a few days of deployment, let's note here what the frequency is and figure out next steps.
Flags: needinfo?(babadie)
We're seeing a very high number of revisions with a base revision that is not in mozilla-unified, around 50% of all the revisions we have analyzed.
Flags: needinfo?(babadie)

All of the ways to make this work perfectly in general are far too involved at this point. I'm going to say improvements here is WONTFIX and we'll most likely need to keep relying on best effort.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.