Closed
Bug 1489630
Opened 6 years ago
Closed 6 years ago
Mark AutoApplyAsyncTestAttributes as MOZ_RAII
Categories
(Core :: Panning and Zooming, enhancement, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
Following up from bug 1465616 comments 172 and 173:
(In reply to Kashav Madan [:kashav] from comment #172)
> (In reply to Kartikaya Gupta (email:kats@mozilla.com) (parental leave) from
> comment #147)
> > nit: add a MOZ_RAII decoration here
>
> Tried adding this, but ran into OS X build failures on Try [1]. From my
> understanding, this is because we're returning a dynamically-allocated
> instance of the RAII class in APZSampler::ApplyAsyncTestAttributes, which
> MOZ_STACK_CLASS [2] doesn't seem to like (correct me if I'm mistaken).
>
> [1]
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=382c69a0cbc49ef9207186dfca9c72554a2e76cc&selectedJob=1
> 94110261
> [2]
> https://searchfox.org/mozilla-central/rev/
> 71ef4447db179639be9eff4471f32a95423962d7/mfbt/Attributes.h#558-564
(In reply to Kartikaya Gupta (email:kats@mozilla.com) (parental leave) from comment #173)
> Ah, ok. That's fine, although given that there's only one call site to the
> APZSampler function we could have inlined that into the call site, and
> created all of the instances on the stack instead of via MakeUnique.
I will implement Kats' suggestion here.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9007343 [details]
Bug 1489630 - Mark AutoApplyAsyncTestAttributes as MOZ_RAII. r=kats
Kartikaya Gupta (email:kats@mozilla.com) (parental leave) has approved the revision.
Attachment #9007343 -
Flags: review+
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55a0a83b8f82
Mark AutoApplyAsyncTestAttributes as MOZ_RAII. r=kats
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•