Closed
Bug 1489791
Opened 6 years ago
Closed 6 years ago
[de-xbl] Remove calendar-caption binding.
Categories
(Calendar :: Lightning Only, enhancement)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
6.6
People
(Reporter: arshad, Assigned: arshad)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
arshad
:
review+
|
Details | Diff | Splinter Review |
Opening binding and replacing it with xul elements. Binding link - https://searchfox.org/comm-central/source/calendar/base/content/calendar-item-bindings.xml#14
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9007480 -
Flags: review?(mkmelin+mozilla)
Comment 3•6 years ago
|
||
Comment on attachment 9007480 [details] [diff] [review] calendar-caption.patch Review of attachment 9007480 [details] [diff] [review]: ----------------------------------------------------------------- Since this is calendar/ someone from there should review ::: calendar/base/content/dialogs/calendar-event-dialog-reminder.xul @@ +48,4 @@ > </hbox> > </vbox> > > + <hbox class="calendar-caption" align="center" id="reminder-details-caption"> here and elsewhere, note that the id comes first, then align the attributes ::: calendar/base/content/dialogs/calendar-summary-dialog.xul @@ +349,5 @@ > > <!-- Description --> > <box id="item-description-box" hidden="true" orient="vertical" flex="1"> > <spacer class="default-spacer"/> > + <hbox class="calendar-caption" align="center"> while you're here, for the hboxes you're adding, if they are missing an id you could go ahead and add one
Attachment #9007480 -
Flags: review?(mkmelin+mozilla) → feedback+
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9007480 -
Attachment is obsolete: true
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9008721 [details] [diff] [review] calendar-caption.patch hey check the id values of the calendar captions and also flag someone who is right person to review from calendars team.
Attachment #9008721 -
Flags: feedback?(mkmelin+mozilla)
Comment 6•6 years ago
|
||
Comment on attachment 9008721 [details] [diff] [review] calendar-caption.patch Review of attachment 9008721 [details] [diff] [review]: ----------------------------------------------------------------- nit: in the commit message "Bug 1489791 - ", not "Bug 1489791: " You can flag MakeMyDay or Philipp for review ::: calendar/base/content/dialogs/calendar-event-dialog-reminder.xul @@ +104,5 @@ > > + <hbox class="calendar-caption" id="reminder-actions-caption" align="center"> > + <label value="&reminder.action.label;" control="reminder-actions-menulist" > + class="header"/> > + <separator class="groove" flex="1"/> Please make id the first attribute And align attributes beneath each other (at least when the line needs to wrap) <label value="&reminder.action.label;" control="reminder-actions-menulist" class="header"/> Goes in the other places too of course
Attachment #9008721 -
Flags: feedback?(mkmelin+mozilla)
Assignee | ||
Updated•6 years ago
|
Attachment #9009040 -
Flags: review?(makemyday)
Comment 8•6 years ago
|
||
Comment on attachment 9009040 [details] [diff] [review] calendar-caption.patch Review of attachment 9009040 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks good, but please fix the style of the commit message when updating the reviwer for checkin to what magnus mentioned in comment 6.
Attachment #9009040 -
Flags: review?(makemyday) → review+
Assignee | ||
Comment 9•6 years ago
|
||
Attachment #9009040 -
Attachment is obsolete: true
Attachment #9009434 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 10•6 years ago
|
||
We really need a try run. I had two patches presented for landing so far that caused test failures: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=28496a4ad1127d65ad7a31c3a19db77b476137d9
Comment 12•6 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d197d42b67d8 Remove calendar-caption binding. r=MakeMyDay
Updated•6 years ago
|
Target Milestone: --- → 6.6
You need to log in
before you can comment on or make changes to this bug.
Description
•