Closed
Bug 1489806
Opened 6 years ago
Closed 6 years ago
Avoid |using namespace js::...| across different js engine components
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
To reduce coupling between parts of the engine, I'd like to avoid top-level |using namespace js::...| for other components than the one the file belongs to. This patch removes most of them.
Some remaining cases:
- builtin/ReflectParse.cpp uses js::frontend
- wasm/AsmJS.cpp uses js::frontend
- irregexp/NativeRegExpMacroAssembler.cpp uses js::jit
- util/Unicode.cpp uses js::unicode
|
Assignee | |
Comment 1•6 years ago
|
||
To reduce coupling between components of engine, avoid top-level |using
namespace js::...;| between distinct components. This fixes most but a
few very intertwined cases remain.
MozReview-Commit-ID: 1ftg5aIADpt
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9007493 [details]
Bug 1489806 - Avoid using namespaces across modules of js/src
Jeff Walden [:Waldo] has approved the revision.
Attachment #9007493 -
Flags: review+
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7b1d18e629b
Avoid using namespaces across modules of js/src r=jwalden
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•