Closed
Bug 1490241
Opened 6 years ago
Closed 6 years ago
CFR Doorhanger: Allow for localized and string overrides on buttons
Categories
(Firefox :: Messaging System, enhancement, P3)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: andreio, Assigned: andreio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
As discussed https://github.com/mozilla/activity-stream/commit/21268904be632c4d74f1fa981e852412a94794ef#r30402848 we should update getStrings method to allow localized and string overrides the way the schema defines it.
Currently blocked on bug 1486617 that will expose PageActions and allow to add (more) unit tests for this patch.
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/475472776246b36f63d03a1c6e7c99fa56325d3b
Fix Bug 1490241 - CFR fluent and string overrides should both have attributes (#4420)
|
|
||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Iteration: --- → 64.1 (Sep 14)
|
|
||
Comment 3•6 years ago
|
||
status-firefox64:
--- → fixed
Target Milestone: --- → Firefox 64
|
|
||
Comment 4•6 years ago
|
||
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout
Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
|
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•