Closed Bug 1490734 Opened 6 years ago Closed 6 years ago

Fresh profile can sometimes display no card in the third card position

Categories

(Firefox :: New Tab Page, defect, P1)

64 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 64
Iteration:
64.1 - Sep 14
Tracking Status
firefox63 --- verified
firefox64 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(3 files)

To test: 1. Fresh profile 2. New tab for about:home Expected: should see three cards for recommendations. Actual: two cards and one empty one. It's an initialized or even order issue, not sure what caused it.
Assignee: nobody → sdowne
Iteration: --- → 64.1 (Sep 14)
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/ca16e25654981f8f4de4f7d1ba55ed9dd80ff996 Fixes bug 1490734 - Fresh profile can sometimes display no card in the third card position (#4417)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1489962
Priority: -- → P1
Backout by btara@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout Relanded: https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
Comment on attachment 9012943 [details] Fixes bug 1490734 - Fresh profile can sometimes display no card in the third card position Approval Request Comment [Feature/Bug causing the regression]: None [User impact if declined]: User experience impacted with missing content and lost revenue. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: 1. Fresh profile 2. New tab for about:home Expected: should see three cards for recommendations. Actual: two cards and one empty one. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: tests, already verified on nightly, changes are not huge. [String changes made/needed]: None
Attachment #9012943 - Flags: approval-mozilla-beta?
Comment on attachment 9012943 [details] Fixes bug 1490734 - Fresh profile can sometimes display no card in the third card position P1, uplift accepted for 63 beta 11, thanks.
Attachment #9012943 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I was unable to reproduce this issue with following builds on Windows 10, Mac OS 10.12, Ubuntu 16.04 Build ID 20180912100128 Build ID 20180910132416 Build ID 20180911101647 Build ID 20180912220514 Build ID 20180927143327 I tested the the latest Nightly build and CI/treeherder beta build (63.ob11)on Windows 10, Mac OS 10.12, Ubuntu 16.04. All three recommended cards appear as expected. Version 64.0a1 Build ID 20181001100147 Version 63.0b11 Build ID 20181001131022
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: