Closed Bug 1491004 Opened 6 years ago Closed 6 years ago

Improve code coverage speed in removing useless files at compile time

Categories

(Testing :: Code Coverage, enhancement)

Product:
Testing
Component:
Code Coverage
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: calixte, Assigned: marco)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1491004 - Set CFLAGS and CXXFLAGS in toolchain.configure for coverage builds. r=chmanchester
(deleted), text/x-phabricator-request
Details
Bug 1491004 - Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium
(deleted), text/x-phabricator-request
Details
Right now, we remove useless files such ones in /usr/include at post-process stage. It would increase speed and reduce gcno/gcda file size to do that at compile time.
A patch is waiting for a review in LLVM: https://reviews.llvm.org/D52033
Attached patch Patch (obsolete) (deleted) — — Splinter Review

I need to verify this actually works.

Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #9040356 - Flags: review?(cdenizet)

Here's the try build, https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbaa03d56518c68b1eeb631fa2315d4adcff8d5a, I'll download it locally and test that the VS stuff is not generated.

And I will morph this bug into doing it for Windows and will open a separate bug for Linux (for Linux we need to switch to Clang first).

Comment on attachment 9040356 [details] [diff] [review] Patch Review of attachment 9040356 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #9040356 - Flags: review?(cdenizet) → review+
Attachment #9040356 - Attachment is obsolete: true
Blocks: 1524932
Attachment #9041053 - Attachment description: Bug 1491004 - Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte → Bug 1491004 - Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a536e231f838 Set CFLAGS and CXXFLAGS in toolchain.configure for coverage builds. r=chmanchester https://hg.mozilla.org/integration/autoland/rev/f1cdf858b026 Exclude Visual Studio files from coverage instrumentation. r=chmanchester,calixte,glandium
Version: Version 3 → Trunk

https://hg.mozilla.org/mozilla-central/rev/a536e231f838
https://hg.mozilla.org/mozilla-central/rev/f1cdf858b026

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?

EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?

(In reply to Edwin Takahashi (:egao, :etakahashi) from comment #10)

:marco - are the contents of https://phabricator.services.mozilla.com/D18510 necessary once migration to python3.5 is complete for mozpack?

EDIT: since the CI environment runs in 2.7 still, looks like this workaround needs to remain present. Once we migrate to 3.5 then this might not longer be needed?

This is not really a workaround, when code coverage is enabled we have to add "--coverage" to CFLAGS and CXXFLAGS.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: