Closed
Bug 1491024
Opened 6 years ago
Closed 6 years ago
Rename userScripts manifest properties to be consistent with the manifest property name conventions
Categories
(WebExtensions :: General, enhancement, P1)
WebExtensions
General
Tracking
(firefox64 fixed)
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
Details
Attachments
(1 file)
The userScripts API allows an extension to specify an extension url to be used as the script which can provide custom API methods to the isolated userScript sandboxes, this manifest property is currently named `userScripts.apiScript`.
We should renamed it to `user_scripts.api_script`, so that it follows the same name conventions used by the rest of the manifest properties.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → lgreco
Blocks: 1437098
Status: NEW → ASSIGNED
Iteration: --- → 64.1 (Sep 14)
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9008776 [details]
Bug 1491024 - Rename userScripts manifest property to follow manifest property name conventions. r?mixedpuppy!
Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9008776 -
Flags: review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/f1cc448b5137
Rename userScripts manifest property to follow manifest property name conventions. r=mixedpuppy
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88ba6771fdc0
Backed out changeset f1cc448b5137 for failures on test_ext_userScripts. CLOSED TREE
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1f6617eece2
Rename userScripts manifest property to follow manifest property name conventions. r=mixedpuppy
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 7•6 years ago
|
||
Cab you please add some STRs to this issue(and a test webext if possible) or mark it as "qe-verify-" ?
Flags: needinfo?(lgreco)
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Victor Carciu from comment #7)
> Cab you please add some STRs to this issue(and a test webext if possible) or
> mark it as "qe-verify-" ?
I'm marking this qe-verify-, as it is tested in the automated tests (and it has also been verified as a side-effect of the QA verification we did for Bug 1437864).
Flags: needinfo?(lgreco) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•